Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The removeUnknownsAndDefaults plugin was removing attributes that were used in CSS selectors, which is problematic because that breaks styles!
We should be checking if that attribute is used as part of an attribute selector before we commit to removing it.
I've implemented it to only check for the existence of an attribute selector that references the key, rather than actually compare the value, because attribute selectors are complicated. For example:
[preserveAspectRatio][preserveAspectRatio=][preserveAspectRatio^="x"]In future, we can explore making a more robust utility. But for now, let's at least not break SVGs.
Related