fix(cleanupIds): handle no-uri-encoded references#1982
Merged
Conversation
SethFalco
reviewed
Apr 24, 2024
Member
SethFalco
left a comment
SethFalco
left a comment
There was a problem hiding this comment.
I've left a comment as I believe there is a vulnerability in this version.
Overall, the issue and solution makes sense though. Thanks for submitting a patch!
… simplify the test cases.
SethFalco
approved these changes
Apr 25, 2024
Member
|
Thanks for spotting the issue and submitting a patch! This will be released by the end of the month. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #1981 .