Add minimal pastebin behaviour#1546
Conversation
Allows users to create plaintext 'pastes' from the webui. The interface
can be enabled with the `--pastebin` cli argumen and also requires
`--file-uploads` to be enabled.
A textarea input & title field are presented to the user. When
the paste form is submitted, we create a plaintext file in memory and
pass it to the exiting upload form. This means the pastebin behaviour
inherits all behaviours associated with uploading files (eg: filename
collisions).
If no title is given we generate a `paste-{random-6-ch}.txt` filename,
otherwise the given title is suffixed with `.txt`, if required, and used
as the filename.
|
I love this! Could you move the button a bit so save some space? I don't think we need a shortcut for this, Please continue implementing this with tests and your other TODOs. :) |
|
Do you think you'll have some time soon-ish to work on this so I can ship this in the next release of miniserve? |
|
Yep I will try and get it out tonight. |
Creates a "stack" for upload + mkdir tools, with pastebin next to it taking any remaining space. When the window is small, all tools are stacked vertical. If pastebin is not enabled, upload + mkdir are rendered horizontally with width: min-content.
|
This is where I got up to tonight. I went with a system to stack upload+mkdir on the left if needed when pastebin is present, otherwise they're as they were-ish. There is an issue at around 860-760px wide, we run out of crushing space so the tools start to overrun the container. Couldn't really get it to behave in a satisfying way but it's kind of non-blocking IMO? It's solvable with media queries but if I started doing that I felt like it was better to rework them all to be mobile-first first. I looked at tests but for upload + mkdir we build the http requests directly in the test then post to the server which isn't really applicable here as the paste interface just hits the upload interface via javascript. It would just read exactly the same as the regular upload test. I added one pretty dumb one, and wasn't sure how to check the server refused to start without I also changed the language from "paste" to "file" as that seemed a bit more obvious. Dunno if 
|
svenstaro
changed the title
svenstaro
left a comment
svenstaro
left a comment
There was a problem hiding this comment.
I really like the effort you put into wrangling the CSS. Would just like to see some tests and then I think we're actually good to merge this. The JS looks fine, maybe sprinkle in a few comments about what you're doing and we're good.
Only one test really applicable to the pastebin functionality.
|
Probably ready to go I think. The CSS is still a bit awkward at some between-breakpoint limbo sizes but not in a blocking way. |
|
Could you make |
|
Very cool! |
2 participants
Fixes #1475
My usage for this is wanting to share text between systems on an authenticated network, any more complicated "password protection", "secret" or "expiry" behaviour seen on other pastebins is out of scope. Protecting the "pastebin" can be done by existing methods in
miniserveif desired. Viewing pastes is done by viewing the file in browser. I think that's inline with miniserves objectives, "For when you really just want to serve somefilestext content over HTTP right now! ".The PR allows users to create plaintext 'pastes' from the webui. The interface can be enabled with the
--pastebincli argument and also requires--file-uploadsto be enabled.A textarea (required) input & title input (optional) are presented to the user. When the paste form is submitted, we create a plaintext file in memory and pass it to the exiting upload form. This means the pastebin behaviour inherits all behaviours associated with uploading files (eg: filename collisions).
If no title is given we generate a
paste-{random-6-ch}.txtfilename, otherwise the given title is suffixed with.txt, if required, and used as the filename.This is a WIP/POC to see if the idea is acceptable, things not addressed:
-Pwas already taken)