feat: enable some GFM extensions for readme render#1545
feat: enable some GFM extensions for readme render#1545svenstaro merged 2 commits intosvenstaro:masterfrom
Conversation
Please try this out in all of the themes and set reasonable colors :)
I think your selection is fine. I don't think granular control is required. |
Previously, table headers used --table_header_text_color only when the header contained an <a> element. While this worked for listings, tables in the README fell back to --table_text_color, making headers invisible under the Squirrel theme. This change applies --table_header_text_color to all <th> elements by default.
I looked into style.scss, and found out that table thead tr th,
table tbody tr td {
padding: 0.5625rem 0.625rem;
font-size: 0.875rem;
color: var(--table_text_color);
text-align: left;
line-height: 1.125rem;
}
table thead tr th {
padding: 0.5rem 0.625rem 0.625rem;
font-weight: bold;
}
// Other styles
th a,
th a:visited,
.chevron {
color: var(--table_header_text_color);
}So I add the color to table thead tr th {
padding: 0.5rem 0.625rem 0.625rem;
font-weight: bold;
color: var(--table_header_text_color);
}Thus, the theme squirrel has different colors for the table's header background and text in the README. Other themes use the same color or a slightly different color (#f8f8f0 vs #f8f8f2) for text and header text, so the header is visible in the previous commit. Now they are still visible. |
|
Do you have a test file for me so I can reproduce your exact results? |
I just added these lines to this repo's README and executed ~strikethrough~
| foo | bar |
| --- | --- |
| baz | qux |
- [ ] foo
- [x] bar
https://example.comAs for the CI test, should I write code in
|
|
This is great! Thanks. I don't think we necessarily need a test for this. |
This PR enables 4 GFM extensions for --readme to solve #1544 :
~text~for adding a delete line| element | element |for tablehttps://example.cominto<a></a>- [ ] fooHere is a showcase for the current effect:
TODO