Ignore failure on file hash calculation#1542
Merged
svenstaro merged 3 commits intosvenstaro:masterfrom Jan 7, 2026
Merged
Conversation
the function does not exist and we don't use the value
Owner
|
Seems fine, thanks! |
svenstaro
added a commit
that referenced
this pull request
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File hash calculation based on
crypto.subtle.digest("SHA-256", fileBuffer)may fail in some cases:crypto.subtleis not available under a non secure context (e.g. non-HTTPS intranet like http://192.168.1.1)ArrayBufferfor files larger than 2GB, and an alternative way of hashing is not available without introducing third-party packages (Bug 27755 - Using the Subtle Crypto Interface with Streams w3c/webcrypto#73)This PR is created to allow hashing failures and avoid breaking the user experience.
Fixes #1541