I still get colors because log entries aren't the only things that is colored. There's also colored for the manual prints. I reckon these should also be affected. You should be able to do this using https://docs.rs/colored/latest/colored/control/static.SHOULD_COLORIZE.html.

I still get colors because log entries aren't the only things that is colored.

Hi. I'm afraid I don't get it clearly. The code path with auto argument is the same as its current code. Are you also planning to fix this path as well?

Yes, what I'm saying is that users passing in --log-color never will probably expect to receive absolutely no colored output but currently the output that is printed via colored is still colored while the logged lines using log are not. I think users would expect output to be uncolored, no matter the output facility.

Yes, what I'm saying is that users passing in --log-color never will probably expect to receive absolutely no colored output but currently the output that is printed via colored is still colored while the logged lines using log are not. I think users would expect output to be uncolored, no matter the output facility.

Oh, I see. Let me handle it.

Do you want to pick this up and finish it?

Do you want to pick this up and finish it?

Sure. Sorry for the late response. The new Github homepage make me forget this PR.

Done. PTAL

Thanks!