File & directory deletion feature#1518
Conversation
This allows the encoding set definitions to be `include!`ed into integration tests
|
@svenstaro could you approve the CI? |
|
hopefully we'll see this feature in the next release after a 2-year wait 😂 |
|
@svenstaro the PR is ready for your review when convenient - just wanted to give you a heads up in case it wasn't on your radar |
|
Thanks for picking this up! Sorry, I'll need a few days. I'm quite busy currently. |
|
@svenstaro No worries at all. Take your time |
|
Hi @svenstaro! Just a gentle ping on this PR when you have a moment. No rush at all - I know you mentioned being busy. |
svenstaro
left a comment
svenstaro
left a comment
There was a problem hiding this comment.
Sorry for taking such a long time here! This looks clean af. Just remove the debug prints and I'll merge immediately.
| println!("===== {file_path:?} ====="); | ||
| println!("{get_url}, {del_url}"); |
There was a problem hiding this comment.
Do we want this here? I'm ok with debug print but this formatting isn't kosher. Let's switch to something less gaudy. :)
| println!("===== {file_path:?} ====="); | ||
| println!("{get_url}, {del_url}"); |
|
Eh I'll just fix this myself real quick :) |
|
Thanks for finishing this up! |
3 participants
This is continuation of #1093. I had to create a new PR since I don't have permission to push to that PR