Fix --no-symlinks not filtering files and dirs nested in symlinks#1495
Merged
svenstaro merged 1 commit intosvenstaro:masterfrom Jun 24, 2025
Merged
Fix --no-symlinks not filtering files and dirs nested in symlinks#1495svenstaro merged 1 commit intosvenstaro:masterfrom
svenstaro merged 1 commit intosvenstaro:masterfrom
Conversation
svenstaro
requested changes
May 6, 2025
Owner
svenstaro
left a comment
svenstaro
left a comment
There was a problem hiding this comment.
Looks good. Just a few nits.
Comment on lines
+388
to
+404
| if !no_symlinks { | ||
| return true; | ||
| } | ||
|
|
||
| let mut full_path = base_path.clone(); | ||
|
|
||
| for component in path.components() { | ||
| full_path.push(component); | ||
| if full_path.is_symlink() { | ||
| return false; | ||
| } | ||
| } | ||
|
|
||
| true |
Owner
There was a problem hiding this comment.
This logic is now complex enough that I'd like a few comments sprinkled in here.
svenstaro
added a commit
that referenced
this pull request
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if you can guess the name of a symlinked dir, and the name of files or directories nested inside, miniserve will not prevent you from accessing them, even when
--no-symlinksis passed.