move favicon and css to stable, non-random routes#1472
Merged
svenstaro merged 1 commit intosvenstaro:masterfrom Feb 6, 2025
Merged
move favicon and css to stable, non-random routes#1472svenstaro merged 1 commit intosvenstaro:masterfrom
svenstaro merged 1 commit intosvenstaro:masterfrom
Conversation
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Favicon and stylesheet are currently served at random paths in order to avoid collisions. However, this causes problems with running multi-replica deployments as well as caching, because the path is not stable across multiple instances/restarts of miniserve.
In order to address this, this PR moves the paths to stable routes prefixed by "__miniserve_internal", which should provide enough protection from accidental collisions.