Merged
Conversation
- Split `ContexualError` into `StartError` & `RuntimeError` - Made sure every `RuntimeError` variant has an accurate status code
Contributor
Author
|
Btw I intend to queue #1093 after this one. |
4 tasks
svenstaro
requested changes
Jan 29, 2024
Owner
svenstaro
left a comment
svenstaro
left a comment
There was a problem hiding this comment.
I really like this! Maybe just rename the Start stuff to Startup and we should be good.
Owner
|
Very nice stuff! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
I noticed that the
ResponseErrorimpl forContexualErrorwas not very complete. Many variants simply default to 500-ISE by wildcard match.So I tried to fix that, but in the process I realised that some error variants are only encountered at program startup and not at runtime. Therefore I think it's much more appropriate to put them in separate enums.
Change summary
ContexualErrorintoStartError&RuntimeError&AuthParseErrorRuntimeErrorvariant has an accurate status code