Optional enable compression middleware to reduce response size (disabled by default)#1315
Merged
svenstaro merged 2 commits intosvenstaro:masterfrom Jan 16, 2024
zuisong:opt_compress_response
Merged
Optional enable compression middleware to reduce response size (disabled by default)#1315svenstaro merged 2 commits intosvenstaro:masterfrom zuisong:opt_compress_response
svenstaro merged 2 commits intosvenstaro:masterfrom
zuisong:opt_compress_response
Conversation
svenstaro
requested changes
Jan 15, 2024
Owner
svenstaro
left a comment
svenstaro
left a comment
There was a problem hiding this comment.
Thanks! Just a tiny code change.
Did you perform some benchmarks by any chance?
Contributor
Author
|
I didn't do benchmark, but my server egress bandwidth is very low, and I'm transmitting plain text files, which really need compression. |
svenstaro
requested changes
Jan 16, 2024
Owner
|
Super nice, thanks! |
svenstaro
added a commit
that referenced
this pull request
Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#523
#497
This PR adds an optional section to turn on compress response, turned off by default, and a note in the help docs about the impact of turning this on.