Skip to content

Ignore readonly metadata and handle errors instead#1310

Merged
svenstaro merged 1 commit intosvenstaro:masterfrom
ViRb3:master
Jan 13, 2024
Merged

Ignore readonly metadata and handle errors instead#1310
svenstaro merged 1 commit intosvenstaro:masterfrom
ViRb3:master

Conversation

@ViRb3
Copy link
Copy Markdown
Contributor

@ViRb3 ViRb3 commented Jan 11, 2024

Fixes #994, check the issue for more information. Tested on Windows, and also confirmed that real permission error throws 401 as requested. Logs show like this:

Thu, 11 Jan 2024 22:19:25 +0000 [ERROR] Insufficient permissions to create file in \?\C:\Users\User\Downloads\test\test.pdf

@ViRb3
Copy link
Copy Markdown
Contributor Author

ViRb3 commented Jan 12, 2024

@svenstaro Sorry I'll be away from my PC for a while, can you please fix the formatting so this PR doesn't stay hanging? Thanks

@svenstaro svenstaro merged commit 0b52969 into svenstaro:master Jan 13, 2024
@svenstaro
Copy link
Copy Markdown
Owner

Thanks! We don't have a test for it but I trust your fix. :)

svenstaro added a commit that referenced this pull request Jan 13, 2024
@LaurentGrenet
Copy link
Copy Markdown

I just tested... and I confirm it works fine.
Many thanks to both of you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to upload a/o create folder on any other disk than C:\ on Win10

3 participants