Feature: Show size in byte#1261
Conversation
|
Sorry for ignoring this for so long! Would you perhaps like to rebase this? I promise I'll review it quickly. :) |
OK |
Lzzzzzt
force-pushed
the
show-size-in-byte
branch
from
39c9264 to
cb0dd89
Compare
I'm done |
|
Ok, so I'm thinking: Perhaps this should be a frontend option like the sorting method and sorting order? It would be consistent since it's a display thing like those other options. There could be a button in the "Size" row that would allow you to toggle this (and it'd change the query parameter). We can still have something like |
Agreed! Keeping it consistent with sorting options and adding a toggle in the “Size” row makes sense. I’m good with the --default-size-display flag too. |
Lzzzzzt
force-pushed
the
show-size-in-byte
branch
from
cb0dd89 to
a5c32b5
Compare
It seems there is no suitable place for the button in the table header, I think the |
|
Do you want to rebase this and for the time being just exchange |
Add a cli option that show file size in bytes rather than KB or MB, etc.
Signed-off-by: Lzzzt <[email protected]>
Ok |
Signed-off-by: Lzzzt <[email protected]>
Lzzzzzt
force-pushed
the
show-size-in-byte
branch
from
a5c32b5 to
d2e6c0d
Compare
I've rebased and changed cli args, could you review the code? |
| (build_link("size", &format!("{}", size), sort_method, sort_order)) | ||
| @if show_exact_bytes { | ||
| span.mobile-info.size { | ||
| (maud::display(format!("{}B", size.as_u64()))) |
There was a problem hiding this comment.
Shall we display it the same as the human format with {} B instead of {}B?
2 participants
Add a cli option that show file size in bytes rather than KB or MB, etc.
solve the #1236.