Merged
Conversation
Contributor
Author
|
Hi 👋 I don't believe this was a feature ever requested or in the issue tracker (that I was able to find) but it's one that I use myself. Feel free to completely discard if you don't think it is something you want to support. |
This adds a new flag namely `--pretty-urls` that when enabled will serve the equivalent `.html` if it exists. Very much the same approach that [`netlify` uses](https://docs.netlify.com/site-deploys/post-processing/). It can be quite useful when having hrefs like `/about` serve `/about.html`.
nlopes
force-pushed
the
nlopes-pretty-urls
branch
from
2907719 to
1fd6060
Compare
svenstaro
requested changes
Aug 6, 2023
Owner
svenstaro
left a comment
svenstaro
left a comment
There was a problem hiding this comment.
Seems like a cool feature! Good code too, just small nits.
- remove info logging - add comment to clarify logic
svenstaro
approved these changes
Aug 7, 2023
Owner
|
Good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new flag namely
--pretty-urlsthat when enabled will serve the equivalent.htmlif it exists.Very much the same approach that
netlifyuses.
It can be quite useful when having hrefs like
/aboutserve/about.html.