Encode single quote in directory path name#1191
Merged
svenstaro merged 3 commits intosvenstaro:masterfrom Aug 3, 2023
Merged
Conversation
Author
|
This is about issue #1190 |
Owner
|
Tested and working well, thanks! |
Owner
|
I'll merge after you fix the formatting issue. |
Author
|
I'm assuming that running |
Author
|
I see that one of the CI tests failed and gave a useful error message, so I went ahead and made that change. |
svenstaro
added a commit
that referenced
this pull request
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well I took a stab at it. Took me a minute just to be able to read rust code, since I don't have any experience with rust. However, with just a couple line changes I did get it to work. Not sure if this is how you would have liked it to have been done though.