Implement instant_print_lines argument#583
Merged
svenstaro merged 6 commits intosvenstaro:masterfrom Dec 10, 2023
josherrickson:master
Merged
Implement instant_print_lines argument#583svenstaro merged 6 commits intosvenstaro:masterfrom josherrickson:master
instant_print_lines argument#583svenstaro merged 6 commits intosvenstaro:masterfrom
josherrickson:master
Conversation
svenstaro
requested changes
Dec 8, 2023
Owner
svenstaro
left a comment
svenstaro
left a comment
There was a problem hiding this comment.
Great first contribution! A few nitpicks but the overall concept looks sound!
svenstaro
reviewed
Dec 8, 2023
Owner
|
Could you also rebase to get rid of the merge commit into your branch? |
Enables the activity to look 'in progress' immediately upon execution
Contributor
Author
|
I've added wasm32 support. I also rebased. PS I picked |
Owner
|
Great work! Not bad for your first Rust contribution. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #582; adding functionality to remove any time-delay in printing the first n number of lines.