Reimplement bruteforce module#408
Conversation
svenstaro
left a comment
svenstaro
left a comment
There was a problem hiding this comment.
I really like this and it looks awesome! The general logic in the code is good but I think we can clean up the surrounding code a bit and maybe even slim this down a bit.
src/modules/bruteforce.rs
Outdated
| } | ||
| } | ||
|
|
||
| // color a string rainbow |
There was a problem hiding this comment.
Might it be more maintainable to use colorful here? We will have to check whether it breaks the web version, though.
There was a problem hiding this comment.
I didn't know that crates!
I'll look into it.
There was a problem hiding this comment.
Can we use 24-bit colors?
colorful seems not to work without 24-bit color support.
Even in 2022, there are still a few terminal emulators without full-color support (macOS terminal, for example)
There was a problem hiding this comment.
By the way, can I use 256 colors instead of ANSI 8 colors?
It will make the step of the rainbow colors smoother.
|
Super nice. Very cool module and clean implementation. Thanks! |
|
How about expanding this a bit and having it crack more than just a single hash? |
|
Does this match up to what you expected? Untitled.mov |
|
Hell yes :D |
|
Then I'll make a PR with it soon! |
2 participants
Close #7.
genact.mp4