Repository navigation
Luxembourgish, Dzongkha: use :year, :month and :day in date.order - #1187
Open
ChandraChaan wants to merge 1 commit into
Open
ChandraChaan wants to merge 1 commit into
ChandraChaan wants to merge 1 commit into
Conversation
sunny
approved these changes
Nov 4, 2026
Author
|
Thanks for the approval, @sunny! The CI workflow on this PR is still waiting for a maintainer to approve the run. Could you approve it, and merge if it passes? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
lb.ymlanddz.yml,date.orderholds translated words instead of the keys Rails expects:Rails'
translated_date_order(actionview/lib/action_view/helpers/date_helper.rb) raises"<locale>.date.order only accepts :year, :month and :day"for anything else, sodate_selectanddatetime_selectfail for these two locales.This replaces the values with
:year,:month,:dayin the order the existing translations had them (year, month, day, as inen.yml). I did not change the order itself; if Luxembourgish should be day, month, year, that is a separate decision. I also added a line to theUnreleasedsection ofCHANGELOG.md.I added a spec in
spec/other/locale_files_spec.rbthat checksdate.order, when present, is a permutation of year, month and day in everyrails/locale/*.yml.I couldn't run Ruby locally, so I ran the suite on a fork:
expected ["dz.yml", "lb.yml"].empty? to return true, got falseatlocale_files_spec.rb:22.2272 examples, 0 failures, 1 pending; the pending example is the existing "Fix missing pluralizations" one).The commit in this PR is the squashed form of the fix branch (identical tree).