🦋 Changeset detected

Latest commit: 4e8b170

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Pull Request Test Coverage Report for Build 9559791113

Details

• 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.009%) to 90.373%

Totals
Change from base Build 9549359097:	0.009%
Covered Lines:	2997
Relevant Lines:	3205

💛 - Coveralls

Pull Request Test Coverage Report for Build 9559807428

Details

• 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.009%) to 90.373%

Totals
Change from base Build 9549359097:	0.009%
Covered Lines:	2997
Relevant Lines:	3205

💛 - Coveralls

Pull Request Test Coverage Report for Build 9560319146

Details

• 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.009%) to 90.373%

Totals
Change from base Build 9560317447:	0.009%
Covered Lines:	2997
Relevant Lines:	3205

💛 - Coveralls

Hey! Within my project I've managed to get three different parser errors which seem to have the root cause lying in the usage of snippets https://github.com/gitbutlerapp/gitbutler/actions/runs/9582690351/job/26422242794?pr=4109.

I was wondering if this was related & fixed by this PR, or whether I should make a separate issue.

In my case, it doesn't seem to be a problem when when have a snippet passed directly as a prop, but it causes parser errors whenever I define a snippet at the top level and then consume it elsewhere within the same svelte file.

IE:

<div class="commit-list-item">
	<div class="commit-card-wrapper">
		{@render moveCommitDropzone()}
	</div>
</div>

{#snippet moveCommitDropzone()}
	<Dropzone
		accepts={actions.acceptMoveCommit.bind(actions)}
		ondrop={actions.onMoveCommit.bind(actions)}
		fillHeight
	>
		{@render branchDropDropzone()}

		{#snippet overlay({ hovered, activated })}
			<CardOverlay {hovered} {activated} label="Move here" />
		{/snippet}
	</Dropzone>
{/snippet}

{#snippet branchDropDropzone()}
	<Dropzone
		accepts={actions.acceptBranchDrop.bind(actions)}
		ondrop={actions.onBranchDrop.bind(actions)}
		fillHeight
	>
		{@render children()}

		{#snippet overlay({ hovered, activated })}
			<CardOverlay {hovered} {activated} label="Move here" />
		{/snippet}
	</Dropzone>
{/snippet}

/home/runner/work/gitbutler/gitbutler/app/src/lib/components/BranchCard/Dropzones.svelte
  0:0  error  Parsing error: Cannot read properties of undefined (reading 'type')

/home/runner/work/gitbutler/gitbutler/app/src/lib/components/CommitDragItem.svelte
  0:0  error  Parsing error: Cannot set properties of undefined (setting 'parent')

/home/runner/work/gitbutler/gitbutler/app/src/lib/components/CommitList.svelte
  0:0  error  Parsing error: Cannot read properties of undefined (reading 'typeAnnotation')

I've actually ended up building the branch locally, and can confirm that this PR does fix my snippet related errors too!!! Thanks for your hard work