Bring package up to speed in 2021 #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I think we should also look at updating the syntax highlighting which might fix #8 . For that you could go over to language-tools and generate a JSON file from the YAML file and copy over the result - hope this would be enough to do that. |
Contributor
Author
|
Yes, fixing syntax highlighting is a very priority too. It's really a bummer when you have to chose between the right syntax for the job and preserving syntax highlighting for the rest of your file. @dummdidumm We merge this, and I'll open a new PR for syntax highlighting if I manage to get it up to date? |
Member
|
Sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
I surmise you haven't used Atom in a while...
I have made a series of adjustments to bring this extension up to speed with the latest Svelte Language Server.
With this fixes, the following capabilities of the language server have been restored in my Atom:
The changes I've made are the following:
Upgrade to latest language server
Workaround incomplete workspaceFolders: this fixes detection of
tsconfig.jsonby the language server, hence provide enhanced TS supportUpgrade to latest atom-languageclient, which seemingly makes the previous fix useless 😅
Spawn the language server process with the system Node, if available, instead of the Electron's embedded one, to fix loading of
svelte.config.jsI have also added a note in the README that this package maintenance has resumed, since it hadn't been updated in a while...