Skip to content

Conversation

@Conduitry
Copy link
Member

Fixes #4258. The tests also had to be rearranged a bit to support custom compiler options during server-side-rendering tests, and I've tidied up a couple of things there.

Copy link
Member

@tanhauhau tanhauhau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah.. the tooling change may have conflict with my PR #4251, (i'll fix it later).

anyway, overall LGTM

@tanhauhau
Copy link
Member

oh and probably need to update the docs for how to make ssr + hydratable works

@Conduitry Conduitry merged commit 7494509 into sveltejs:master Jan 14, 2020
@Conduitry Conduitry deleted the gh-4258 branch January 14, 2020 17:11
jesseskinner pushed a commit to jesseskinner/svelte that referenced this pull request Feb 27, 2020
taylorzane pushed a commit to taylorzane/svelte that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide way to opt out of attributes on SSR'd <head> elements used for hydration

2 participants