allow components without slots to have whitespace as only child #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1017 +/- ##
==========================================
+ Coverage 92.08% 92.09% +<.01%
==========================================
Files 115 115
Lines 4297 4302 +5
Branches 1369 1373 +4
==========================================
+ Hits 3957 3962 +5
Misses 147 147
Partials 193 193
Continue to review full report at Codecov.
|
Member
|
This just restores 1.46.0 behavior, right? Any thoughts on how to handle sending slots into components that don't accept them? I'm kind of torn. |
Member
Author
|
Correct. Opened a new issue about components without slots: #1020 |
sacrosanctic
pushed a commit
to sacrosanctic/svelte
that referenced
this pull request
Dec 24, 2024
sync kit docs Co-authored-by: Rich-Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1007