perf: remove lodash#3038
Conversation
🦋 Changeset detectedLatest commit: 1d8172c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This comment was marked as resolved.
This comment was marked as resolved.
ghostdevv
force-pushed
the
lodash
branch
2 times, most recently
from
e0d377c to
3fd27e2
Compare
dummdidumm
left a comment
dummdidumm
left a comment
There was a problem hiding this comment.
looks good except groupBy. groupBy creates an array per entry with all the objects that match the key
yea! that's what it should do. It matches the |
|
Sorry that sentence was unclear - your implementation is not doing what it's supposed to. Instead of creating an array per entry it just takes the first occurrence of a match and assigns it to the key |
omg yea 🤦♀️ |
2 participants
Remove the dependency on
lodashreplacing with native code anddefufor merging objects. The only thing I'm not certain is replacing_.mergewithdefuas there could be different behavior, but I think it'll be fine. The new tests are AI generated, checked by me, and run both before and after this PR to help ensure I didn't break anything