Skip to content

Commit 565abf9

Browse files
Recognise modern CSS properties in svelte check (#3122)
* fix: recognise modern CSS properties such as corner-shape Bump vscode-css-languageservice to 6.3.10 so svelte-check no longer reports valid properties like corner-shape as unknown. * Update CSS plugin fixtures for newer MDN urls and color formats * Run prettier on the CSS plugin test fixtures * Revert the new test. It already served the demonstration purpose. We don't need to test this every time. ---------
1 parent bf2993e commit 565abf9

4 files changed

Lines changed: 49 additions & 9 deletions

File tree

‎.changeset/css-corner-shape.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'svelte-language-server': patch
3+
'svelte-check': patch
4+
---
5+
6+
fix: recognise modern CSS properties such as corner-shape by updating vscode-css-languageservice

‎packages/language-server/package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
"svelte": "^4.2.19",
6767
"svelte2tsx": "workspace:~",
6868
"typescript-auto-import-cache": "^0.3.6",
69-
"vscode-css-languageservice": "~6.3.5",
69+
"vscode-css-languageservice": "~6.3.10",
7070
"vscode-html-languageservice": "~5.4.0",
7171
"vscode-languageserver": "9.0.1",
7272
"vscode-languageserver-protocol": "3.17.5",

‎packages/language-server/test/plugins/css/CSSPlugin.test.ts‎

Lines changed: 37 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ describe('CSS Plugin', () => {
7474
"Specifies the height of the content area, padding area or border area \\(depending on 'box\\-sizing'\\) of certain boxes\\.\n\n" +
7575
'![Baseline icon](data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMTgiIGhlaWdodD0iMTAiIHZpZXdCb3g9IjAgMCA1NDAgMzAwIiBmaWxsPSJub25lIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPgogIDxzdHlsZT4KICAgIC5ncmVlbi1zaGFwZSB7CiAgICAgIGZpbGw6ICNDNEVFRDA7IC8qIExpZ2h0IG1vZGUgKi8KICAgIH0KCiAgICBAbWVkaWEgKHByZWZlcnMtY29sb3Itc2NoZW1lOiBkYXJrKSB7CiAgICAgIC5ncmVlbi1zaGFwZSB7CiAgICAgICAgZmlsbDogIzEyNTIyNTsgLyogRGFyayBtb2RlICovCiAgICAgIH0KICAgIH0KICA8L3N0eWxlPgogIDxwYXRoIGQ9Ik00MjAgMzBMMzkwIDYwTDQ4MCAxNTBMMzkwIDI0MEwzMzAgMTgwTDMwMCAyMTBMMzkwIDMwMEw1NDAgMTUwTDQyMCAzMFoiIGNsYXNzPSJncmVlbi1zaGFwZSIvPgogIDxwYXRoIGQ9Ik0xNTAgMEwzMCAxMjBMNjAgMTUwTDE1MCA2MEwyMTAgMTIwTDI0MCA5MEwxNTAgMFoiIGNsYXNzPSJncmVlbi1zaGFwZSIvPgogIDxwYXRoIGQ9Ik0zOTAgMEw0MjAgMzBMMTUwIDMwMEwwIDE1MEwzMCAxMjBMMTUwIDI0MEwzOTAgMFoiIGZpbGw9IiMxRUE0NDYiLz4KPC9zdmc+) _Widely available across major browsers (Baseline since 2015)_\n\n' +
7676
'Syntax: auto | <length\\-percentage \\[0,∞\\]> | min\\-content | max\\-content | fit\\-content | fit\\-content\\(<length\\-percentage \\[0,∞\\]>\\) | <calc\\-size\\(\\)> | <anchor\\-size\\(\\)>\n\n' +
77-
'[MDN Reference](https://developer.mozilla.org/docs/Web/CSS/height)'
77+
'[MDN Reference](https://developer.mozilla.org/docs/Web/CSS/Reference/Properties/height)'
7878
},
7979
range: Range.create(0, 12, 0, 24)
8080
});
@@ -119,7 +119,7 @@ describe('CSS Plugin', () => {
119119
value:
120120
'Defines character set of the document\\.\n\n' +
121121
'![Baseline icon](data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMTgiIGhlaWdodD0iMTAiIHZpZXdCb3g9IjAgMCA1NDAgMzAwIiBmaWxsPSJub25lIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPgogIDxzdHlsZT4KICAgIC5ncmVlbi1zaGFwZSB7CiAgICAgIGZpbGw6ICNDNEVFRDA7IC8qIExpZ2h0IG1vZGUgKi8KICAgIH0KCiAgICBAbWVkaWEgKHByZWZlcnMtY29sb3Itc2NoZW1lOiBkYXJrKSB7CiAgICAgIC5ncmVlbi1zaGFwZSB7CiAgICAgICAgZmlsbDogIzEyNTIyNTsgLyogRGFyayBtb2RlICovCiAgICAgIH0KICAgIH0KICA8L3N0eWxlPgogIDxwYXRoIGQ9Ik00MjAgMzBMMzkwIDYwTDQ4MCAxNTBMMzkwIDI0MEwzMzAgMTgwTDMwMCAyMTBMMzkwIDMwMEw1NDAgMTUwTDQyMCAzMFoiIGNsYXNzPSJncmVlbi1zaGFwZSIvPgogIDxwYXRoIGQ9Ik0xNTAgMEwzMCAxMjBMNjAgMTUwTDE1MCA2MEwyMTAgMTIwTDI0MCA5MEwxNTAgMFoiIGNsYXNzPSJncmVlbi1zaGFwZSIvPgogIDxwYXRoIGQ9Ik0zOTAgMEw0MjAgMzBMMTUwIDMwMEwwIDE1MEwzMCAxMjBMMTUwIDI0MEwzOTAgMFoiIGZpbGw9IiMxRUE0NDYiLz4KPC9zdmc+) _Widely available across major browsers (Baseline since 2015)_\n\n' +
122-
'[MDN Reference](https://developer.mozilla.org/docs/Web/CSS/@charset)'
122+
'[MDN Reference](https://developer.mozilla.org/docs/Web/CSS/Reference/At-rules/@charset)'
123123
},
124124
textEdit: TextEdit.insert(Position.create(0, 7), '@charset'),
125125
tags: []
@@ -157,7 +157,9 @@ describe('CSS Plugin', () => {
157157
label: 'none',
158158
documentation: {
159159
kind: 'markdown',
160-
value: 'The element and its descendants generates no boxes\\.'
160+
value:
161+
'The element and its descendants generates no boxes\\.\n\n' +
162+
'![Baseline icon](data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMTgiIGhlaWdodD0iMTAiIHZpZXdCb3g9IjAgMCA1NDAgMzAwIiBmaWxsPSJub25lIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciPgogIDxzdHlsZT4KICAgIC5ncmVlbi1zaGFwZSB7CiAgICAgIGZpbGw6ICNDNEVFRDA7IC8qIExpZ2h0IG1vZGUgKi8KICAgIH0KCiAgICBAbWVkaWEgKHByZWZlcnMtY29sb3Itc2NoZW1lOiBkYXJrKSB7CiAgICAgIC5ncmVlbi1zaGFwZSB7CiAgICAgICAgZmlsbDogIzEyNTIyNTsgLyogRGFyayBtb2RlICovCiAgICAgIH0KICAgIH0KICA8L3N0eWxlPgogIDxwYXRoIGQ9Ik00MjAgMzBMMzkwIDYwTDQ4MCAxNTBMMzkwIDI0MEwzMzAgMTgwTDMwMCAyMTBMMzkwIDMwMEw1NDAgMTUwTDQyMCAzMFoiIGNsYXNzPSJncmVlbi1zaGFwZSIvPgogIDxwYXRoIGQ9Ik0xNTAgMEwzMCAxMjBMNjAgMTUwTDE1MCA2MEwyMTAgMTIwTDI0MCA5MEwxNTAgMFoiIGNsYXNzPSJncmVlbi1zaGFwZSIvPgogIDxwYXRoIGQ9Ik0zOTAgMEw0MjAgMzBMMTUwIDMwMEwwIDE1MEwzMCAxMjBMMTUwIDI0MEwzOTAgMFoiIGZpbGw9IiMxRUE0NDYiLz4KPC9zdmc+) _Widely available across major browsers (Baseline since 2015)_'
161163
},
162164
sortText: ' ',
163165
tags: [],
@@ -407,6 +409,38 @@ describe('CSS Plugin', () => {
407409
}
408410
}
409411
}
412+
},
413+
{
414+
label: 'oklab(3646.4910000000004% -2.60976 -25.13803)',
415+
textEdit: {
416+
newText: 'oklab(3646.4910000000004% -2.60976 -25.13803)',
417+
range: {
418+
end: {
419+
character: 21,
420+
line: 0
421+
},
422+
start: {
423+
character: 17,
424+
line: 0
425+
}
426+
}
427+
}
428+
},
429+
{
430+
label: 'oklch(3646.491% 25.27313 264.073)',
431+
textEdit: {
432+
newText: 'oklch(3646.491% 25.27313 264.073)',
433+
range: {
434+
end: {
435+
character: 21,
436+
line: 0
437+
},
438+
start: {
439+
character: 17,
440+
line: 0
441+
}
442+
}
443+
}
410444
}
411445
]);
412446
});

‎pnpm-lock.yaml‎

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)