🦋 Changeset detected

Latest commit: e5723d9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Been having a blast experimenting with this today.

It seems there are two approaches for adding third party routers (sorry if I'm stating the obvious):

Option A - loadComponent

hooks.js

import { Router, createRouter } from '@roxi/routify'
import routes from '../.routify/routes.default.js'

/** @type {import('@sveltejs/kit').Handle} */
export async function handle({ request, loader }) {

    // create a router instance
    const router = createRouter({ routes })

    // let router run async functions, eg. fetch dynamic imports, run preloads, guards etc.
    await router.url.replace(request.path) 

    // create SSR node    
    const ssrNode = await loader.loadComponent({ id: 'src/routes/root.svelte' });
    
    // inject the router into  `src/routes/root.svelte`
    const rendered = ssrNode.module.default.render({ router });    
...

src/routes/root.svelte

<script>
    import { Router } from '@roxi/routify'
    export let router
</script>

<Router {router} />

Option B - plain SSR

hooks.js

import { Router, createRouter } from '@roxi/routify'
import routes from '../.routify/routes.default.js'

/** @type {import('@sveltejs/kit').Handle} */
export async function handle({ request, loader }) {

    const router = createRouter({ routes })
    await router.url.replace(request.path)
    const rendered = Router.render({router})

Option B doesn't require a root.svelte file, but I'm not sure about pros and cons of using loadComponent

Option B will not return the list of JS and CSS files needed to populate the page's head the way that loadComponent will

I'm afraid I think this is a bit of a non-starter, aside from whether it's a desirable API — it makes server-side code-splitting completely impossible.

Supporting other routers is a non-goal as far as I'm concerned — the router is a large part of what SvelteKit is. So my inclination is to close this, unless there's another use case that we want to try and enable?

I do think there are cases where you might want to use a different router as @pngwn frequently points out. And I don't think that SSR code splitting would necessarily be a blocker since not all adapters support it and it's an optional feature on those that do. That being said, this PR is out-of-date and I'm not tremendously motivated to update it since the Routify folks never did much with it