Skip to content

breaking: universal node config takes precedence over server#16400

Merged
Rich-Harris merged 4 commits into
version-3from
resolve-todo
Jul 18, 2026
Merged

breaking: universal node config takes precedence over server#16400
Rich-Harris merged 4 commits into
version-3from
resolve-todo

Conversation

@teemingc

@teemingc teemingc commented Jul 18, 2026

Copy link
Copy Markdown
Member

This PR resolves two TODOs surrounding page node configs:

  1. Verified that we should return undefined if there are no page config keys
  2. Standardised the +page.server.js exports taking precedence over the +page.js ones (this matches how we resolve all the other page options)

@changeset-bot

changeset-bot Bot commented Jul 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: a0c10f9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-svelte-dev

pkg-svelte-dev Bot commented Jul 18, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from a0c10f9:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/a0c10f9b75764c73aa50341ee264e61a0b736d96

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16400

};
}

// TODO 3.0 always return `current`? then we can get rid of `?? {}` in other places

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not much point in doing this since we test if this is undefined before falling back to the +server.js exported config

if (page?.config && endpoint?.config) {

@teemingc teemingc changed the title chore: remove a todo breaking: universal node config takes precedence over server Jul 18, 2026
Comment thread .changeset/nice-mammals-move.md Outdated
Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>
@Rich-Harris
Rich-Harris merged commit 428ee1a into version-3 Jul 18, 2026
20 of 21 checks passed
@Rich-Harris
Rich-Harris deleted the resolve-todo branch July 18, 2026 22:12
Rich-Harris pushed a commit that referenced this pull request Jul 20, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to version-3, this PR
will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`version-3` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `version-3`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @sveltejs/[email protected]

### Major Changes

- breaking: `config` exported from a universal route file takes
precedence over a server one
([#16400](#16400))

- breaking: consistent special filename patterns
([#16382](#16382))

### Minor Changes

- feat: support sourcemaps in production
([#16412](#16412))

- feat: support function validators for environment variables
([#16402](#16402))

- feat: better error logging
([#16374](#16374))

### Patch Changes

- fix: don't treat callable standard schemas as function param matchers
([#16403](#16403))

- fix: reject malformed streamed data encoding
([#16423](#16423))

- fix: hide stack traces for internal errors like 404s
([#16411](#16411))

- perf: match only unpaired surrogates when escaping HTML
([#16407](#16407))

- fix: don't report empty environment variables as missing
([#16401](#16401))

- chore: clarify which hooks run during server route resolution
([#16397](#16397))
## @sveltejs/[email protected]

### Minor Changes

- feat: better error logging
([#16374](#16374))

### Patch Changes

- Updated dependencies
[[`5220191`](5220191),
[`8cb2f7d`](8cb2f7d),
[`b88c7a7`](b88c7a7),
[`a6ea113`](a6ea113),
[`6446f64`](6446f64),
[`58f1789`](58f1789),
[`09774a2`](09774a2),
[`c542fdd`](c542fdd),
[`aedaa27`](aedaa27),
[`428ee1a`](428ee1a),
[`fefb3ae`](fefb3ae)]:
  - @sveltejs/[email protected]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants