breaking: consistent special filename patterns#16382
Merged
Merged
Conversation
|
Install the latest version of pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/b37230a6a2bf2ba213a7173b938bdc42f44c2607Open in |
🦋 Changeset detectedLatest commit: c315920 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…name/directory-based server-only detection and allowing server-only code to leak into client bundles
This commit fixes the issue reported at packages/kit/src/exports/vite/index.js:758
## Bug
In `packages/kit/src/exports/vite/index.js` the `plugin_guard` `load`/`handler` computes whether a module is server-only:
```js
let is_server_only = normalized === '$app/env/private' || normalized === '$app/server';
if (id.startsWith(normalized_cwd) && !id.startsWith(normalized_node_modules)) {
is_server_only ??= server_only_module_pattern.test(id);
is_server_only ??=
server_only_directory_pattern.test(id) &&
!id.startsWith(normalized_routes + '/') &&
!id.startsWith(normalized_assets + '/');
}
if (!is_server_only) return;
```
`is_server_only` is initialized from `===` comparisons, so it is **always** a boolean (`true`/`false`), never `null`/`undefined`.
`a ??= b` only assigns when `a` is nullish. Since `is_server_only` is `false` for the overwhelmingly common case (the module is not `$app/server` / `$app/env/private`), the RHS of both `??=` statements never executes:
```js
let x = false; x ??= true; // x is still false
```
## Impact
The filename pattern (`*.server.*`) and `server/` directory checks are effectively dead code. Modules that should be flagged server-only via filename/directory conventions are no longer detected, so `find_chain` never fires and the guard that documentation/docs/30-advanced/50-server-only-modules.md promises is disabled. Server-only code (potentially containing secrets) can be silently bundled into the client — a security regression introduced by the refactor in commit caf79f3.
## Fix
Switch both `??=` to `||=` so the checks run whenever `is_server_only` is still falsy, matching the pre-refactor single boolean-OR behavior.
Co-authored-by: Vercel <vercel[bot]@users.noreply.github.com>
Co-authored-by: Rich-Harris <[email protected]>
teemingc
reviewed
Jul 19, 2026
teemingc
reviewed
Jul 19, 2026
teemingc
reviewed
Jul 19, 2026
Co-authored-by: Tee Ming <[email protected]>
teemingc
reviewed
Jul 19, 2026
teemingc
reviewed
Jul 19, 2026
| expect(remote_module_pattern.test('dir/remote.js')).toBe(true); | ||
| expect(remote_module_pattern.test('dir/module.remote.ts')).toBe(true); | ||
| expect(remote_module_pattern.test('dir/module.remote.test.js')).toBe(true); | ||
| expect(remote_module_pattern.test('dir/module.remotely.js')).toBe(false); |
Member
There was a problem hiding this comment.
Suggested change
| expect(remote_module_pattern.test('dir/module.remotely.js')).toBe(false); | |
| expect(remote_module_pattern.test('dir/module.remotely.js')).toBe(false); | |
| expect(remote_module_pattern.test('remote/index.js')).toBe(false); |
Might be worth testing the directory name case for both module patterns?
teemingc
approved these changes
Jul 19, 2026
Rich-Harris
pushed a commit
that referenced
this pull request
Jul 20, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to version-3, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `version-3` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `version-3`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @sveltejs/[email protected] ### Major Changes - breaking: `config` exported from a universal route file takes precedence over a server one ([#16400](#16400)) - breaking: consistent special filename patterns ([#16382](#16382)) ### Minor Changes - feat: support sourcemaps in production ([#16412](#16412)) - feat: support function validators for environment variables ([#16402](#16402)) - feat: better error logging ([#16374](#16374)) ### Patch Changes - fix: don't treat callable standard schemas as function param matchers ([#16403](#16403)) - fix: reject malformed streamed data encoding ([#16423](#16423)) - fix: hide stack traces for internal errors like 404s ([#16411](#16411)) - perf: match only unpaired surrogates when escaping HTML ([#16407](#16407)) - fix: don't report empty environment variables as missing ([#16401](#16401)) - chore: clarify which hooks run during server route resolution ([#16397](#16397)) ## @sveltejs/[email protected] ### Minor Changes - feat: better error logging ([#16374](#16374)) ### Patch Changes - Updated dependencies [[`5220191`](5220191), [`8cb2f7d`](8cb2f7d), [`b88c7a7`](b88c7a7), [`a6ea113`](a6ea113), [`6446f64`](6446f64), [`58f1789`](58f1789), [`09774a2`](09774a2), [`c542fdd`](c542fdd), [`aedaa27`](aedaa27), [`428ee1a`](428ee1a), [`fefb3ae`](fefb3ae)]: - @sveltejs/[email protected] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two special kinds of modules in SvelteKit projects: server-only modules and remote modules.
*.server.tsis server-only, as is*.server.*.ts— any.server.infix works*.remote.tsis remote, but*.remote.*.tsis notThis inconsistency is weird. It's also weird that
server.tsisn't a server-only module. Similarly, it's annoying thatremote.tsisn't treated as a remote module, as it's not uncommon to have a folder structure like this...The
indexpart ofindex.remote.tsis there just because you need something, but the name to identify it by is already in the path —my/feature. Forcing people to add junk to the start of the filename just to satisfy arbitrary internal assumptions is unsportsmanlike. Simpler to be able to say that if your module includes a 'server' segment in the filename it's server-only; same for remote modules.Closes #16318
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits