Skip to content

fix: use root for kit.env.dir fallback#15792

Merged
Rich-Harris merged 14 commits into
version-3from
fix-resolve-env-to-root
Jun 26, 2026
Merged

fix: use root for kit.env.dir fallback#15792
Rich-Harris merged 14 commits into
version-3from
fix-resolve-env-to-root

Conversation

@teemingc

@teemingc teemingc commented May 4, 2026

Copy link
Copy Markdown
Member

Follow up to #15469 where we started using the Vite root instead of process.cwd().

The fallback value of kit.env.dir should not use process.cwd() when validating the config as later on in process_config it will correctly be resolve to the Vite root setting


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot

changeset-bot Bot commented May 4, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 15163ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@changeset-bot

changeset-bot Bot commented May 4, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 751c128

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot

Copy link
Copy Markdown

@Rich-Harris Rich-Harris merged commit 271d728 into version-3 Jun 26, 2026
17 checks passed
@Rich-Harris Rich-Harris deleted the fix-resolve-env-to-root branch June 26, 2026 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants