feat: add option to configure preload setup#14917
Closed
teemingc wants to merge 17 commits into
Closed
Conversation
🦋 Changeset detectedLatest commit: 782ccbc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
|
This PR might still be useful for disabling preloading and treeshaking it when it's not needed, such as for offline apps #12664 we might have to introduce an option to turn it off manually EDIT: note to self to automatically disable preloading for single and inline apps. Noticed a bunch of Tauri SvelteKit apps in the showcase and disabling the mouse event listener should really help battery life |
6 tasks
teemingc
commented
Jul 1, 2026
teemingc
commented
Jul 1, 2026
teemingc
commented
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #12664
This PR moves the client preloading logic into its own module and adds a new config option (name can be bikeshed) to
completely disableconfigure link option preloading. It needs to be a config option because it's not a simple task to detect if there are nodata-sveltekit-preload-*attributes in the app and automatically disable the listener for it.TODO
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits