Skip to content

feat: add option to configure preload setup#14917

Closed
teemingc wants to merge 17 commits into
version-3from
feat-dynamically-import-preload
Closed

feat: add option to configure preload setup#14917
teemingc wants to merge 17 commits into
version-3from
feat-dynamically-import-preload

Conversation

@teemingc

@teemingc teemingc commented Nov 11, 2025

Copy link
Copy Markdown
Member

closes #12664

This PR moves the client preloading logic into its own module and adds a new config option (name can be bikeshed) to completely disable configure link option preloading. It needs to be a config option because it's not a simple task to detect if there are no data-sveltekit-preload-* attributes in the app and automatically disable the listener for it.

TODO

  • refactor to allow specifying which options can be used rather than disabling the whole setup

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot

changeset-bot Bot commented Nov 11, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 782ccbc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@teemingc teemingc marked this pull request as ready for review November 12, 2025 17:20
@teemingc teemingc added the needs-decision Not sure if we want to do this yet, also design work needed label Nov 13, 2025
@teemingc

teemingc commented Jan 14, 2026

Copy link
Copy Markdown
Member Author

This PR might still be useful for disabling preloading and treeshaking it when it's not needed, such as for offline apps #12664 we might have to introduce an option to turn it off manually

EDIT: note to self to automatically disable preloading for single and inline apps. Noticed a bunch of Tauri SvelteKit apps in the showcase and disabling the mouse event listener should really help battery life

@teemingc teemingc marked this pull request as draft January 14, 2026 10:27
@teemingc teemingc changed the title chore: separate client preload chore: add option to disable preload setup Feb 28, 2026
@teemingc teemingc removed the needs-decision Not sure if we want to do this yet, also design work needed label Feb 28, 2026
@svelte-docs-bot

Copy link
Copy Markdown

@teemingc teemingc changed the base branch from main to version-3 July 1, 2026 08:04
Comment thread .changeset/nine-pots-repeat.md Outdated
Comment thread .changeset/nine-pots-repeat.md Outdated
@teemingc teemingc changed the title chore: add option to disable preload setup feat: add option to disable preload setup Jul 1, 2026
@teemingc teemingc changed the title feat: add option to disable preload setup feat: add option to configure preload setup Jul 1, 2026
Comment thread .changeset/nine-pots-repeat.md Outdated
@teemingc teemingc closed this Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mousemove event listener is being attached in setup_preload even if I am not using data-sveltekit-preload-[x]="hover"

1 participant