chore: check `WORKERS_CI` env variable to determine if we're building for Cloudflare Workers by teemingc · Pull Request #13733 · sveltejs/kit

teemingc · 2025-04-23T09:10:18Z

This PR detects the WORKERS_CI environment variable so that adapter-auto and adapter-cloudflare can work with Cloudflare's Workers Git integration to build the app without requiring a wrangler configuration from the user.

I've changed the scope of the PR to focus on only the Cloudflare adapter because we'll may end up deprecating adapter-auto. Also, it doesn't work well with adapter-auto since it requires a wrangler config file.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
This message body should clearly illustrate what problems it solves.
Ideally, include a test that fails without this PR but passes with it.

Tests

Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

changeset-bot · 2025-04-23T09:10:22Z

🦋 Changeset detected

Latest commit: eb9cf06

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@sveltejs/adapter-cloudflare	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Co-authored-by: Ben McCann <[email protected]>

…ltejs/kit into feat-adapter-auto-workers-ci

teemingc · 2025-04-24T04:12:53Z

@benmccann I'm not sure if the adapter-auto case for Workers Builds is very useful with this PR because it doesn't "just work" like the other platforms do (since it fails without a Wrangler config file). Would it be useful to generate a basic Wrangler config during the Workers CI so that it just works? Or is it better that users get a deployment error which forces them to setup a wrangler.jsonc file?

svelte-docs-bot · 2025-04-24T04:12:59Z

Preview: https://svelte-dev-git-preview-kit-13733-svelte.vercel.app/

benmccann · 2025-04-24T04:32:12Z

Ah, I guess the PR description is outdated then as it suggests it works without a config

What would a basic config contain? Is there anything we might accidentally omit or get wrong by doing that?

teemingc · 2025-04-24T04:52:56Z

Ah, I guess the PR description is outdated then as it suggests it works without a config

Yeah, I was half-way implementing the generated config but then wasn't sure if it would be a good idea.

What would a basic config contain? Is there anything we might accidentally omit or get wrong by doing that?

The minimum we would need would be:

{
	// `name` is not required since Cloudflare's dashboard requires the user to enter that before the build
	"main": ".svelte-kit/cloudflare/_worker.js",
	// this will be based on the current date
	"compatibility_date": "2025-04-24",
	"assets": {
		"binding": "ASSETS",
		"directory": ".svelte-kit/cloudflare",
	},
	// only required if the user uses `getRequestEvent()` asynchronously.
	// Enabling this doesn't add any polyfills like `nodejs_compat` does so it could be safe to always have this?
	// Otherwise we could only include it if we detect `getRequestEvent()` being used.
	"compatibility_flags": ["nodejs_als"]
}

Another question is: how should we generate the Wrangler config? There are currently two ways to do this:

Simulate a user's Wrangler configuration file.
This is probably the easiest and means writing a new wrangler.jsonc if there is no user configuration file already.
Create a redirected Wrangler configuration.
I'm a bit wary of using this method because if the redirected config exists, the Wrangler deploy and dev commands will always ignore the user's configuration file until the redirect is deleted. Fortunately, Wrangler does warn the user if the redirect config is being used. However, it would be better if we could create a config that acts as a fallback/override rather than a complete replacement. I've asked the Cloudflare team about this option and they recommended validating the user config instead.

teemingc · 2026-01-14T09:49:19Z

We can only progress on this once we start using the Cloudflare Vite plugin to automatically generate a wrangler config file https://developers.cloudflare.com/workers/vite-plugin/reference/programmatic-configuration/

This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to version-3, this PR will be updated. ⚠️

⚠️

⚠️ `version-3` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `version-3`. ⚠️

⚠️

⚠️ # Releases ## @sveltejs/[email protected] ### Major Changes - breaking: require SvelteKit 3 ([#15506](#15506)) ### Patch Changes - Updated dependencies [[`fa335bd`](fa335bd), [`3031d89`](3031d89), [`cb9d416`](cb9d416), [`caf3a18`](caf3a18), [`4777827`](4777827), [`a2792e2`](a2792e2), [`ba36148`](ba36148), [`48e8710`](48e8710), [`e2f3075`](e2f3075), [`047d6a0`](047d6a0), [`87603d1`](87603d1), [`096962c`](096962c), [`d545970`](d545970), [`e2f3075`](e2f3075), [`d06affc`](d06affc), [`8af47eb`](8af47eb), [`e2f3075`](e2f3075), [`5c4d130`](5c4d130), [`3f11f35`](3f11f35), [`caf3a18`](caf3a18), [`8823037`](8823037), [`1d76212`](1d76212), [`0dc0548`](0dc0548), [`00d81fa`](00d81fa)]: - @sveltejs/[email protected] ## @sveltejs/[email protected] ### Major Changes - breaking: upgrade `@cloudflare/workers-types` to 4.20260219.0 ([#15347](#15347)) - breaking: upgrade minimum `wrangler` version to ^4.67.0 ([#15347](#15347)) - breaking: remove `platform.context` in favour of `platform.ctx` ([#15347](#15347)) - breaking: require SvelteKit 3 ([#15506](#15506)) ### Patch Changes - chore: check the `WORKERS_CI` environment variable to determine if we're building for Cloudflare Workers ([#13733](#13733)) - Updated dependencies [[`fa335bd`](fa335bd), [`3031d89`](3031d89), [`cb9d416`](cb9d416), [`caf3a18`](caf3a18), [`4777827`](4777827), [`a2792e2`](a2792e2), [`ba36148`](ba36148), [`48e8710`](48e8710), [`e2f3075`](e2f3075), [`047d6a0`](047d6a0), [`87603d1`](87603d1), [`096962c`](096962c), [`d545970`](d545970), [`e2f3075`](e2f3075), [`d06affc`](d06affc), [`8af47eb`](8af47eb), [`e2f3075`](e2f3075), [`5c4d130`](5c4d130), [`3f11f35`](3f11f35), [`caf3a18`](caf3a18), [`8823037`](8823037), [`1d76212`](1d76212), [`0dc0548`](0dc0548), [`00d81fa`](00d81fa)]: - @sveltejs/[email protected] ## @sveltejs/[email protected] ### Major Changes - chore: use `rolldown` for edge function bundling ([#15432](#15432)) - breaking: write output that conforms to the stable [Netlify Frameworks API](https://docs.netlify.com/build/frameworks/frameworks-api/). ([#15294](#15294)) Deploying and previewing with Netlify CLI now requires [v17.31.0](https://github.com/netlify/cli/releases/tag/v17.31.0) or later. Run `npm i -g netlify-cli@latest` to upgrade. - breaking: require SvelteKit 3 ([#15506](#15506)) - breaking: edge function build target is now `es2022` ([#15432](#15432)) ### Patch Changes - Updated dependencies [[`fa335bd`](fa335bd), [`3031d89`](3031d89), [`cb9d416`](cb9d416), [`caf3a18`](caf3a18), [`4777827`](4777827), [`a2792e2`](a2792e2), [`ba36148`](ba36148), [`48e8710`](48e8710), [`e2f3075`](e2f3075), [`047d6a0`](047d6a0), [`87603d1`](87603d1), [`096962c`](096962c), [`d545970`](d545970), [`e2f3075`](e2f3075), [`d06affc`](d06affc), [`8af47eb`](8af47eb), [`e2f3075`](e2f3075), [`5c4d130`](5c4d130), [`3f11f35`](3f11f35), [`caf3a18`](caf3a18), [`8823037`](8823037), [`1d76212`](1d76212), [`0dc0548`](0dc0548), [`00d81fa`](00d81fa)]: - @sveltejs/[email protected] ## @sveltejs/[email protected] ### Major Changes - chore: migrate from rollup to rolldown ([#15297](#15297)) - breaking: require SvelteKit 3 ([#15506](#15506)) ### Patch Changes - Updated dependencies [[`fa335bd`](fa335bd), [`3031d89`](3031d89), [`cb9d416`](cb9d416), [`caf3a18`](caf3a18), [`4777827`](4777827), [`a2792e2`](a2792e2), [`ba36148`](ba36148), [`48e8710`](48e8710), [`e2f3075`](e2f3075), [`047d6a0`](047d6a0), [`87603d1`](87603d1), [`096962c`](096962c), [`d545970`](d545970), [`e2f3075`](e2f3075), [`d06affc`](d06affc), [`8af47eb`](8af47eb), [`e2f3075`](e2f3075), [`5c4d130`](5c4d130), [`3f11f35`](3f11f35), [`caf3a18`](caf3a18), [`8823037`](8823037), [`1d76212`](1d76212), [`0dc0548`](0dc0548), [`00d81fa`](00d81fa)]: - @sveltejs/[email protected] ## @sveltejs/[email protected] ### Major Changes - breaking: require SvelteKit 3 ([#15506](#15506)) ### Patch Changes - Updated dependencies [[`fa335bd`](fa335bd), [`3031d89`](3031d89), [`cb9d416`](cb9d416), [`caf3a18`](caf3a18), [`4777827`](4777827), [`a2792e2`](a2792e2), [`ba36148`](ba36148), [`48e8710`](48e8710), [`e2f3075`](e2f3075), [`047d6a0`](047d6a0), [`87603d1`](87603d1), [`096962c`](096962c), [`d545970`](d545970), [`e2f3075`](e2f3075), [`d06affc`](d06affc), [`8af47eb`](8af47eb), [`e2f3075`](e2f3075), [`5c4d130`](5c4d130), [`3f11f35`](3f11f35), [`caf3a18`](caf3a18), [`8823037`](8823037), [`1d76212`](1d76212), [`0dc0548`](0dc0548), [`00d81fa`](00d81fa)]: - @sveltejs/[email protected] ## @sveltejs/[email protected] ### Major Changes - chore: use `rolldown` for edge function bundling ([#15432](#15432)) - breaking: edge function build target is now `es2022` ([#15432](#15432)) ### Patch Changes - Updated dependencies [[`fa335bd`](fa335bd), [`3031d89`](3031d89), [`cb9d416`](cb9d416), [`caf3a18`](caf3a18), [`4777827`](4777827), [`a2792e2`](a2792e2), [`ba36148`](ba36148), [`48e8710`](48e8710), [`e2f3075`](e2f3075), [`047d6a0`](047d6a0), [`87603d1`](87603d1), [`096962c`](096962c), [`d545970`](d545970), [`e2f3075`](e2f3075), [`d06affc`](d06affc), [`8af47eb`](8af47eb), [`e2f3075`](e2f3075), [`5c4d130`](5c4d130), [`3f11f35`](3f11f35), [`caf3a18`](caf3a18), [`8823037`](8823037), [`1d76212`](1d76212), [`0dc0548`](0dc0548), [`00d81fa`](00d81fa)]: - @sveltejs/[email protected] ## @sveltejs/[email protected] ### Major Changes - breaking: require Node 22 or newer ([#12548](#12548)) ### Minor Changes - breaking: require Vite 8 and `vite-plugin-svelte` 7 ([#15542](#15542)) ## @sveltejs/[email protected] ### Major Changes - breaking: TypeScript 6 is now the minimum required version ([#15930](#15930)) - breaking: upgrade to cookie v1. Cookie names must now contain only ASCII characters ([#13386](#13386)) - breaking: require Node 22 or newer ([#12548](#12548)) - breaking: remove the `preloadStrategy` option. `modulepreload` will always be used ([#15256](#15256)) - breaking: default the cookie `path` option to `'/'` ([#15398](#15398)) - breaking: remove `@sveltejs/kit/node/polyfills` ([#15430](#15430)) - breaking: add `config.kit.output.linkHeaderPreload` to preload using the `Link` header ([#15939](#15939)) - breaking: require `@sveltejs/vite-plugin-svelte` v7 ([#15371](#15371)) - breaking: remove `createEntries` from the `Builder` object passed to adapter functions ([#15509](#15509)) - breaking: remove the deprecated CSRF `checkOrigin` option in favor of `trustedOrigins` ([#15437](#15437)) - breaking: the `delta` property now only exists for `popstate` navigation events ([#15522](#15522)) - breaking: remove deprecated `pragma` header in version polling for improved CORS support ([#15428](#15428)) - breaking: require Svelte 5.48.0 or newer ([#15371](#15371)) - chore: change `error`, `isHttpError`, `redirect`, and `isRedirect` to refer to public type instead of internal class ([#15250](#15250)) - breaking: require Vite 8. Provides new functionality even for existing Vite 8 users such as faster builds with Vite hook filters and more powerful SvelteKit adapters with the Vite environment API ([#15371](#15371)) - breaking: remove `data-sveltekit-*` option `'off'` in favour of `false` ([#15907](#15907)) ### Minor Changes - feat: resolve paths using the Vite config `root` option instead of `process.cwd()` to better support monorepo configurations such as Vitest workspaces ([#15469](#15469)) - chore: deprecate `Response` helpers in favor of platform-provided alternatives ([#15448](#15448)) - feat: explicit env vars ([#15934](#15934)) ### Patch Changes - fix: remove check for svelte.config.js before running `sync` ([#15946](#15946)) - fix: generate a placeholder tsconfig.json to squelch sync-time warnings ([#15948](#15948)) - chore: remove dependency on kleur ([#12548](#12548)) - chore: remove dependency on `set-cookie-parser` ([#15384](#15384)) - fix: allow use of `$app/env/public` in service workers ([#15950](#15950)) ## @sveltejs/[email protected] ### Major Changes - breaking: require Node 22 or newer ([#12548](#12548)) ### Patch Changes - chore: remove dependency on kleur ([#12548](#12548)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Chew Tee Ming added 3 commits April 23, 2025 15:54

simplify workers and pages distinction

0f0c26a

support workers ci in adapter auto

0004d36

add todo

fa08a55

teemingc added pkg:adapter-cloudflare pkg:adapter-auto labels Apr 23, 2025

Chew Tee Ming added 3 commits April 23, 2025 17:32

remove todo

1868b8c

improve error message

38b2940

spacing

7bd425a

benmccann reviewed Apr 23, 2025

View reviewed changes

Comment thread packages/adapter-auto/index.js Outdated

Update packages/adapter-auto/index.js

4a61e60

Co-authored-by: Ben McCann <[email protected]>

benmccann approved these changes Apr 24, 2025

View reviewed changes

Chew Tee Ming added 6 commits April 24, 2025 11:27

validate main key and fix relative import paths

a9ce1c9

Merge branch 'feat-adapter-auto-workers-ci' of https://github.com/sve…

9d2e796

…ltejs/kit into feat-adapter-auto-workers-ci

better comment

24a6ea8

allow spa static assets configuration

b60969b

add validation error reasons

8d4169d

docs formatting

1417d6e

Chew Tee Ming added 3 commits April 24, 2025 12:14

make compatibility date generic

f6b2fcb

mention workers ci

515b1e6

grammar

710510b

teemingc marked this pull request as ready for review April 24, 2025 04:23

benmccann marked this pull request as draft May 7, 2025 17:40

ghostdevv mentioned this pull request Oct 31, 2025

feat: support Cloudflare Workers Builds #14871

Closed

6 tasks

ghostdevv mentioned this pull request Dec 14, 2025

@sveltejs/adapter-auto not detecting Cloudflare Workers #15060

Open

teemingc changed the title ~~feat: support Cloudflare Workers Builds~~ feat: support Workers Builds Jan 14, 2026

teemingc added 3 commits January 14, 2026 17:15

add test for workers_ci

15e31af

format

a3d3e80

update test

daaf6bc

teemingc marked this pull request as ready for review January 14, 2026 09:26

teemingc marked this pull request as draft January 14, 2026 09:48

teemingc mentioned this pull request Jan 14, 2026

fix: ensure injected paths are prefixed with ./ #15163

Merged

6 tasks

teemingc added 4 commits January 14, 2026 19:14

split out

543f192

split out more

9bfdab7

split

5028e2b

add unit test

b622a38

teemingc added this to the 3.0 milestone Jan 29, 2026

benmccann changed the base branch from main to version-3 February 13, 2026 00:42

Remove WORKERS_CI check from Cloudflare adapter

f64d9ea

teemingc commented Feb 25, 2026

View reviewed changes

Comment thread packages/adapter-auto/adapters.js Outdated

Apply suggestion from @teemingc

7ccb7dc

teemingc commented Feb 25, 2026

View reviewed changes

Comment thread .changeset/plenty-cougars-wave.md Outdated

Apply suggestion from @teemingc

e53f113

teemingc removed the pkg:adapter-auto label Feb 25, 2026

Merge branch 'version-3' into feat-adapter-auto-workers-ci

44845f0

teemingc changed the title ~~feat: support Workers Builds~~ chore: check WORKERS_CI env variable when determining if we're building for Cloudflare Workers Feb 25, 2026

teemingc removed this from the 3.0 milestone Feb 25, 2026

teemingc marked this pull request as ready for review February 25, 2026 07:47

teemingc changed the title ~~chore: check WORKERS_CI env variable when determining if we're building for Cloudflare Workers~~ chore: check WORKERS_CI env variable to determine if we're building for Cloudflare Workers Feb 25, 2026

teemingc commented Feb 25, 2026

View reviewed changes

Comment thread .changeset/plenty-cougars-wave.md Outdated

Apply suggestion from @teemingc

eb9cf06

teemingc merged commit d920980 into version-3 Feb 25, 2026
1 of 2 checks passed

teemingc deleted the feat-adapter-auto-workers-ci branch February 25, 2026 07:48

github-actions Bot mentioned this pull request Feb 25, 2026

Version Packages (next) #15311

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

chore: check `WORKERS_CI` env variable to determine if we're building for Cloudflare Workers#13733

chore: check `WORKERS_CI` env variable to determine if we're building for Cloudflare Workers#13733
teemingc merged 30 commits into
version-3from
feat-adapter-auto-workers-ci

teemingc commented Apr 23, 2025 •

edited

Loading

Uh oh!

changeset-bot Bot commented Apr 23, 2025 •

edited

Loading

Uh oh!

Uh oh!

teemingc commented Apr 24, 2025 •

edited

Loading

Uh oh!

svelte-docs-bot Bot commented Apr 24, 2025

Uh oh!

benmccann commented Apr 24, 2025

Uh oh!

teemingc commented Apr 24, 2025 •

edited

Loading

Uh oh!

teemingc commented Jan 14, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

teemingc commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Changesets

Edits

Uh oh!

changeset-bot Bot commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

Uh oh!

teemingc commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

svelte-docs-bot Bot commented Apr 24, 2025

Uh oh!

benmccann commented Apr 24, 2025

Uh oh!

teemingc commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

teemingc commented Jan 14, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

teemingc commented Apr 23, 2025 •

edited

Loading

changeset-bot Bot commented Apr 23, 2025 •

edited

Loading

teemingc commented Apr 24, 2025 •

edited

Loading

teemingc commented Apr 24, 2025 •

edited

Loading