Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shadow endpoints broken on browser back navigation, tries to fetch http://__data.json/ #3718

Closed
pixelmund opened this issue Feb 4, 2022 · 3 comments · Fixed by #3740
Closed

Shadow endpoints broken on browser back navigation, tries to fetch http://__data.json/ #3718

pixelmund opened this issue Feb 4, 2022 · 3 comments · Fixed by #3740
Labels
bug Something isn't working
Milestone
1.0

Comments

@pixelmund
Copy link
Contributor

pixelmund commented Feb 4, 2022 •
edited
Loading

Describe the bug

Hey, i've noticed that the shadow endpoints are broken if you try to navigate back with the default browser navigation, it tries to fetch http://__data.json/.

EDIT: This seems to be happening on every client side navigation.

Reproduction

https://github.com/pixelmund/shadow-endpoints-repro

Steps to reproduce:

2nd Method without pulling the repo:

  • Go to: svemix.com
  • Click on Read the Docs
  • Navigate back

The error is cause because the browser tries to fetch http://__data.json/.

Logs

500
Failed to fetch
TypeError: Failed to fetch
    at Renderer._load (http://localhost:3000/@fs/Users/info/Desktop/DEV/shadow-endpoints/.svelte-kit/runtime/client/start.js:1269:25)
    at async Renderer._get_navigation_result (http://localhost:3000/@fs/Users/info/Desktop/DEV/shadow-endpoints/.svelte-kit/runtime/client/start.js:999:19)
    at async Renderer.update (http://localhost:3000/@fs/Users/info/Desktop/DEV/shadow-endpoints/.svelte-kit/runtime/client/start.js:831:27)
    at async Renderer.handle_navigation (http://localhost:3000/@fs/Users/info/Desktop/DEV/shadow-endpoints/.svelte-kit/runtime/client/start.js:820:3)
    at async Router._navigate (http://localhost:3000/@fs/Users/info/Desktop/DEV/shadow-endpoints/.svelte-kit/runtime/client/start.js:413:3)

System Info

System:
    OS: Windows 10 10.0.22000
    CPU: (16) x64 AMD Ryzen 7 5800X 8-Core Processor
    Memory: 23.70 GB / 31.93 GB
  Binaries:
    Node: 16.2.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.10 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 8.1.1 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22000.120.0), Chromium (97.0.1072.76)
    Internet Explorer: 11.0.22000.120
  npmPackages:
    @sveltejs/adapter-auto: next => 1.0.0-next.17
    @sveltejs/kit: next => 1.0.0-next.260
    svelte: ^3.44.0 => 3.46.4

Severity

blocking an upgrade

Additional Information

No response
@Conduitry Conduitry added the bug Something isn't working label Feb 4, 2022
@Conduitry
Copy link
Member

It looks like the culprit is

kit/packages/kit/src/runtime/client/renderer.js

Line 756 in 647131e

const res = await fetch(`${url.pathname}/__data.json`, {

If url.pathname is /, we need to make sure we're not fetching //__data.json, which will be interpreted as a protocol-relative URL. This would probably also be an issue with other paths ending in a / (if https://kit.svelte.dev/docs#configuration-trailingslash were set so as to allow that to happen).

@kdheepak
Copy link

kdheepak commented Feb 4, 2022 •
edited
Loading

I had to get around this by using rel="external".

Using rel="external" resolves the problem when clicking on internal links. I'm not sure if there's a temporary solution for dealing with the currently broken browser back navigation function.

@livehtml
Copy link

livehtml commented Feb 5, 2022

Yep, quick workaround is manually edit the node_modules/@sveltejs/kit/assets/client/start.js~1269:

const res = await fetch(`${url.pathname == '/' ? '' : url.pathname}/__data.json`, {

PH4NTOMiki added a commit to PH4NTOMiki/kit that referenced this issue Feb 5, 2022
@PH4NTOMiki
fix sveltejs#3718 shadow endpoint fetching if path ends with '/'
d28abad
@PH4NTOMiki PH4NTOMiki mentioned this issue Feb 5, 2022
Merged
5 tasks
@benmccann benmccann added this to the 1.0 milestone Feb 7, 2022
@pixelmund pixelmund mentioned this issue Feb 7, 2022
Closed
@madeleineostoja madeleineostoja mentioned this issue Feb 9, 2022
Closed
@kdheepak kdheepak mentioned this issue Feb 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.0
Development

Successfully merging a pull request may close this issue.

Fix shadow endpoint when ending with slash PH4NTOMiki/kit
5 participants
@benmccann @kdheepak @Conduitry @livehtml @pixelmund