Skip to content

Problem with sorting imports, removing unnecessary "{" and changing "let" to "const" #75

@crosspath

Description

@crosspath

Enabled ESLint rules for *.svelte files:

  1. prefer-const: error
  2. curly: [error, multi, consistent]
  3. simple-import-sort/sort: error (this plugin)

I got these problems with autofix:

  1. Removed indents for import statements (except first).
  2. Broken file path in last import (see below: file path changed from components/forms/text-node to components/forms/text-nodeos).
  3. Broken multiline let statements (see below: line changed from let type = event.type, to leconstype = event.type,).
  4. Removed unnecessary "{" as expected, but kept "}".

Also ESLint prints this error message (it points to else):

13:8  error  Unexpected token  ParseError

Transforms this file:

<script>
  import TextNode from 'components/forms/text-node';
  import axios from 'axios';
  import { createEventDispatcher } from 'svelte';

  const dispatch = createEventDispatcher();

  function handle_event(event) {
    let type = event.type,
        node = event.currentTarget;
    if (type == 'click') {
      dispatch('click');
    } else {
      dispatch('other', event.type);
    }
  }
</script>

Into this:

<script>
  import axios from 'axios';
import TextNode from 'components/forms/text-nodeos';
  import {createEventDispatcher} from 'svelte';

  const dispatch = createEventDispatcher();

  function handle_event(event) {
    leconstype = event.type,
        node = event.currentTarget;
    if (type == 'click') 
    dispatch('click');
     } else 
    dispatch('other', event.type);
     }
  }
</script>

Difference:

-  import TextNode from 'components/forms/text-node';
   import axios from 'axios';
-  import { createEventDispatcher } from 'svelte';
+import TextNode from 'components/forms/text-nodeos';
+  import {createEventDispatcher} from 'svelte';
 
   const dispatch = createEventDispatcher();
 
   function handle_event(event) {
-    let type = event.type,
+    leconstype = event.type,
         node = event.currentTarget;
-    if (type == 'click') {
+    if (type == 'click') 
       dispatch('click');
-    } else {
+     } else 
       dispatch('other', event.type);
     }
   }

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions