fix: NPE issue with testMultipleRuns (googleapis#2050)

prash-mi · web-flow · commit 251d4686d22e · 2022-05-18T15:36:12.000Z
Added a `null` check for `firstPage.getSchema()` as we might get null schema when the job is long running (We get schema using dryRun in such cases) Fixes googleapis#2049 ☕️
diff --git a/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ConnectionImpl.java b/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ConnectionImpl.java
@@ -234,8 +234,10 @@ public BigQueryResult executeSelect(
   BigQueryResult getResultSet(
       GetQueryResultsResponse firstPage, JobId jobId, String sql, Boolean hasQueryParameters) {
     if (firstPage.getJobComplete()
-        && firstPage.getTotalRows()
-            != null) { // firstPage.getTotalRows() is null if job is not complete
+        && firstPage.getTotalRows() != null
+        && firstPage.getSchema()
+            != null) { // firstPage.getTotalRows() is null if job is not complete. We need to make
+      // sure that the schema is not null, as it is required for the ResultSet
       return getSubsequentQueryResultsWithJob(
           firstPage.getTotalRows().longValue(),
           (long) firstPage.getRows().size(),
