Container for querying prometheus#47
Merged
Merged
Conversation
husky-parul
reviewed
Aug 1, 2024
| @@ -0,0 +1,15 @@ | |||
| # Set up | |||
Collaborator
There was a problem hiding this comment.
Can we make sure that all the set up for the project is withing the project? For e.g we are using part of the docker compose from kepler project and part of compose contents from peaks project. It is ok to use import and overide but I would recommend to have all the compose files within the peaks project.
husky-parul
reviewed
Aug 1, 2024
| metrics_list = loadProperties() | ||
|
|
||
|
|
||
| if(os.getenv('PROMETHEUS') != None): |
Collaborator
There was a problem hiding this comment.
I see we are trying to use ENV_VAR but no ENV_VARS has been set in the docker compose file.
husky-parul
requested changes
Aug 1, 2024
husky-parul
left a comment
husky-parul
left a comment
Collaborator
There was a problem hiding this comment.
Please look at my comments.
husky-parul
approved these changes
Aug 8, 2024
Signed-off-by: Gabriela <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.