Repository navigation
Commit f3b74d5
Set --no-js-strongly-connected-components for DDC compiles by default (flutter#193485)
Context: DDC's old module system was sensitive to load order, so
mutual/cyclic imports needed to be combined into a single 'module'
(using a strongly-connected-components/SCC algorithm in our various
build infrastructure).
DDC's new Library Bundle module system doesn't have this restriction, so
we can safely disable SCCs. The net result is that every library emits
one JS artifact, which helps us avoid problems with overly large
connected components causing parse deoptimizations in Chrome/V8. More
artifacts are emitted (so perhaps higher compile time), but the overall
load time is improved - especially for larger apps.
Resolves some of the performance degradations reported in:
flutter#1926871 parent 309cfc5 commit f3b74d5
3 files changed
Lines changed: 30 additions & 5 deletions
File tree
- packages/flutter_tools
- lib/src
- test/general.shard
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
31 | 38 | | |
32 | 39 | | |
33 | 40 | | |
| |||
567 | 574 | | |
568 | 575 | | |
569 | 576 | | |
570 | | - | |
571 | | - | |
572 | | - | |
| 577 | + | |
573 | 578 | | |
574 | 579 | | |
575 | 580 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
349 | 349 | | |
350 | 350 | | |
351 | 351 | | |
| 352 | + | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
| 364 | + | |
| 365 | + | |
| 366 | + | |
| 367 | + | |
| 368 | + | |
| 369 | + | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
352 | 374 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
94 | 94 | | |
95 | 95 | | |
96 | 96 | | |
97 | | - | |
98 | | - | |
99 | 97 | | |
100 | 98 | | |
101 | 99 | | |
| |||
0 commit comments