You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e40fdaa
Browse filesBrowse the repository at this point in the historyBrowse files
Give the Vulkan test context the extensions Impeller requires (flutter#193002)
Impeller's capability check reads the extension lists the embedder
declares rather than querying the driver. It wants `VK_KHR_surface` plus
one WSI extension on the instance, and `VK_KHR_swapchain` on the device.
`TestVulkanContext` enables none of them and reports none, so Impeller
refuses the context:
```
[ERROR:impeller/renderer/backend/vulkan/capabilities_vk.cc(105)] Could not find the surface extension.
[ERROR:impeller/renderer/backend/vulkan/context_vk.cc(187)] Device has insufficient capabilities.
[ERROR:shell/platform/embedder/embedder_surface_vulkan_impeller.cc(78)] Failed to initialize Vulkan Context.
```
So no Impeller Vulkan embedder test can run at all today.
Request the surface extensions the ICD offers, create the logical device
with `VK_KHR_swapchain`, and report both lists through
`FlutterVulkanRendererConfig`. SwiftShader offers all of them. Falls
back to a device without the extension if the ICD refuses it, and
reports nothing when the surface extensions are absent, so a context
that cannot serve Impeller still serves the Skia tests exactly as
before.
None of this is used to present — the tests render into images — but
Impeller will not build a context without it.
Also sets `FlutterVulkanImage.struct_size` in the backing store
producer. The API says it must be `sizeof(FlutterVulkanImage)`; the Skia
path never checks, so leaving it zero went unnoticed.
## Tests
No new ones. This is fixture plumbing whose effect is that the Impeller
tests in the fifth and sixth of the series can run; the existing Skia
Vulkan tests must keep passing, and do.
Fourth of six, from flutter#187525. The fifth and sixth need it.
0 commit comments