Skip to content

Commit af94d2d

Browse files
bkonyisuryaKommana2662
authored andcommitted
[flutter_tools] Add DeviceService app launch and flutter run support for tool extensions (flutter#194589)
Adds `DeviceService` RPC methods (`device.launchApp`, `device.getVmServiceUri`, and `device.stopApp`) and `ExtensionDebuggingOptions` to support building, launching, and stopping applications on tool extension devices via `flutter run`. Also exposes `@protected final Logger logger` on `Device` for subclasses. Part of flutter#190753
1 parent 9267dbd commit af94d2d

20 files changed

Lines changed: 1533 additions & 69 deletions

File tree

‎packages/flutter_tools/lib/src/context/tool_dependencies.dart‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -627,6 +627,7 @@ class ToolDependencies {
627627
androidWorkflow: finalAndroidWorkflow,
628628
buildSystem: finalBuildSystem,
629629
buildTargets: finalBuildTargets,
630+
extensionBuildManager: extensionBuildManager,
630631
extensionManager: extensionManager,
631632
featureFlags: finalFeatureFlags,
632633
iosSimulatorUtils: finalIOSSimulatorUtils,

‎packages/flutter_tools/lib/src/device.dart‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -603,14 +603,19 @@ String getNameForDeviceConnectionInterface(DeviceConnectionInterface connectionI
603603
abstract class Device {
604604
Device(
605605
this.id, {
606-
required Logger logger,
606+
required this.logger,
607607
this._toolContext,
608608
required this.category,
609609
required this.platformType,
610610
required this.ephemeral,
611611
}) : dds = DartDevelopmentService(logger: logger);
612612

613613
final String id;
614+
615+
/// The [Logger] used by this device.
616+
@protected
617+
final Logger logger;
618+
614619
final ToolContext? _toolContext;
615620

616621
@protected

‎packages/flutter_tools/lib/src/experimental/extension_build_manager.dart‎

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,6 @@ base class ExtensionBuildManager {
7171
for (final (ExtensionConnection connection, List<ExtensionBuildTarget> targetList)
7272
in connectionTargets) {
7373
for (final target in targetList) {
74-
if (target.name.isEmpty) {
75-
continue;
76-
}
7774
if (_targetToConnection.containsKey(target.name)) {
7875
// TODO(bkonyi): Include conflicting extension names once extension manifest metadata is wired into ExtensionConnection.
7976
_logger.printWarning('Skipping duplicate build target "${target.name}" from extension.');

0 commit comments

Comments
 (0)