Repository navigation
Commit 3031af1
Revert: [flutter_tools] forward --offline flag to pub.get in update-packages (flutter#193808)
Reverts: [[flutter_tools] forward --offline flag to pub.get in
update-packages](flutter#193619)
Initiated by: @cbracken
Reason for reverting: info • Use 'const' with the constructor to improve
performance. Try adding the 'const' keyword to the constructor
invocation •
packages/flutter_tools/test/commands.shard/hermetic/update_packages_test.dart:315:24
• prefer_const_constructors
Original PR Author: @bkonyi
Reviewed By: @chingjun
The original PR description is provided below:
When running `flutter update-packages --offline`, the `--offline` flag
was parsed and used to validate incompatible option combinations (such
as `--force-upgrade` and `--cherry-pick-package`), but was not forwarded
to the underlying `pub.get` invocations. Forward `offline` through
`_pubGet` to `pub.get` so that `pub` does not attempt network operations
in offline environments.
Fixes flutter#193423
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.1 parent 5aaf66e commit 3031af1
2 files changed
Lines changed: 5 additions & 61 deletions
File tree
- packages/flutter_tools
- lib/src/commands
- test/commands.shard/hermetic
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
243 | 243 | | |
244 | 244 | | |
245 | 245 | | |
246 | | - | |
247 | | - | |
248 | | - | |
249 | | - | |
250 | | - | |
| 246 | + | |
251 | 247 | | |
252 | 248 | | |
253 | 249 | | |
254 | | - | |
255 | | - | |
256 | | - | |
257 | | - | |
258 | | - | |
259 | | - | |
| 250 | + | |
| 251 | + | |
260 | 252 | | |
261 | 253 | | |
262 | 254 | | |
263 | 255 | | |
264 | 256 | | |
265 | 257 | | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | | - | |
271 | | - | |
272 | | - | |
273 | | - | |
274 | | - | |
275 | | - | |
| 258 | + | |
| 259 | + | |
276 | 260 | | |
277 | 261 | | |
278 | 262 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
294 | 294 | | |
295 | 295 | | |
296 | 296 | | |
297 | | - | |
298 | | - | |
299 | | - | |
300 | | - | |
301 | | - | |
302 | | - | |
303 | | - | |
304 | | - | |
305 | | - | |
306 | | - | |
307 | | - | |
308 | | - | |
309 | | - | |
310 | | - | |
311 | | - | |
312 | | - | |
313 | | - | |
314 | | - | |
315 | | - | |
316 | | - | |
317 | | - | |
318 | | - | |
319 | | - | |
320 | | - | |
321 | | - | |
322 | | - | |
323 | | - | |
324 | | - | |
325 | | - | |
326 | | - | |
327 | | - | |
328 | 297 | | |
329 | 298 | | |
330 | 299 | | |
| |||
668 | 637 | | |
669 | 638 | | |
670 | 639 | | |
671 | | - | |
672 | | - | |
673 | | - | |
674 | 640 | | |
675 | 641 | | |
676 | 642 | | |
| |||
683 | 649 | | |
684 | 650 | | |
685 | 651 | | |
686 | | - | |
687 | | - | |
688 | | - | |
689 | | - | |
690 | | - | |
691 | | - | |
692 | 652 | | |
693 | 653 | | |
694 | 654 | | |
| |||
0 commit comments