fix: use ubuntu-22.04 for GLIBC 2.35 compatibility by remorses · Pull Request #23 · sursaone/bun-pty

remorses · 2025-12-30T17:01:08Z

The current workflow uses ubuntu-latest which is Ubuntu 24.04 with GLIBC 2.39.

This causes the built .so files to require GLIBC 2.39, breaking compatibility with older Linux distros.

This PR switches Linux builds to ubuntu-22.04 (GLIBC 2.35) for broader compatibility.

cc @sursaone

Related issues:

Summary by CodeRabbit

Chores
- Adjusted CI runner images from the latest distro to Ubuntu 22.04 for selected Linux builds to ensure consistent GLIBC compatibility and more reliable artifacts. A comment was added clarifying the compatibility rationale.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-12-30T17:01:20Z

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Updated GitHub Actions publish workflow to replace ubuntu-latest runners with ubuntu-22.04 for two matrix entries, and added a comment explaining GLIBC compatibility (ubuntu-latest uses GLIBC 2.39; ubuntu-22.04 uses GLIBC 2.35). No other logic changes.

Changes

Cohort / File(s)	Summary
GitHub Actions Workflow Configuration `\.github/workflows/publish.yml`	Changed matrix runner values from `ubuntu-latest` to `ubuntu-22.04` for `x86_64-unknown-linux-gnu` and `aarch64-unknown-linux-gnu`; added inline comment about GLIBC version compatibility (2.39 vs 2.35).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 I hopped from latest to twenty-two-oh-four,
To match GLIBC fences and run builds once more.
A tiny change, a careful tweak,
Pipelines hum, no build critique.
Happy hops — swift, smooth, and sure! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title states 'ubuntu-22.04 for GLIBC 2.35' but the PR description indicates the initial objective was ubuntu-20.04 for GLIBC 2.31, updated to ubuntu-22.04 due to deprecation. The title aligns with the actual changeset which uses ubuntu-22.04, directly addressing the main fix in the workflow file.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 753d62d and c262cc5.

📒 Files selected for processing (1)

.github/workflows/publish.yml

🚧 Files skipped from review as they are similar to previous changes (1)

.github/workflows/publish.yml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: test (windows-latest, x86_64-pc-windows-gnu)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Copilot

Pull request overview

This PR addresses GLIBC compatibility issues by changing the Linux build runners from ubuntu-latest (Ubuntu 24.04 with GLIBC 2.39) to ubuntu-20.04 (GLIBC 2.31), enabling the built shared libraries to run on older Linux distributions.

Key Changes:

Updated Linux x86_64 build runner from ubuntu-latest to ubuntu-20.04
Updated Linux aarch64 build runner from ubuntu-latest to ubuntu-20.04
Added explanatory comment about GLIBC version compatibility

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bdcb87f and 753d62d.

📒 Files selected for processing (1)

.github/workflows/publish.yml

🧰 Additional context used

🪛 actionlint (1.7.9)

.github/workflows/publish.yml

22-22: label "ubuntu-20.04" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-11-arm", "ubuntu-slim", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-26-xlarge", "macos-26", "macos-15-intel", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

25-25: label "ubuntu-20.04" is unknown. available labels are "windows-latest", "windows-latest-8-cores", "windows-2025", "windows-2022", "windows-11-arm", "ubuntu-slim", "ubuntu-latest", "ubuntu-latest-4-cores", "ubuntu-latest-8-cores", "ubuntu-latest-16-cores", "ubuntu-24.04", "ubuntu-24.04-arm", "ubuntu-22.04", "ubuntu-22.04-arm", "macos-latest", "macos-latest-xl", "macos-latest-xlarge", "macos-latest-large", "macos-26-xlarge", "macos-26", "macos-15-intel", "macos-15-xlarge", "macos-15-large", "macos-15", "macos-14-xl", "macos-14-xlarge", "macos-14-large", "macos-14", "macos-13-xl", "macos-13-xlarge", "macos-13-large", "macos-13", "self-hosted", "x64", "arm", "arm64", "linux", "macos", "windows". if it is a custom label for self-hosted runner, set list of labels in actionlint.yaml config file

(runner-label)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: test (windows-latest, x86_64-pc-windows-gnu)

🔇 Additional comments (1)

.github/workflows/publish.yml (1)

21-21: Excellent documentation of the GLIBC compatibility rationale.

The comment clearly explains the reasoning behind the runner choice and will help future maintainers understand this decision.

yuguorui · 2026-01-09T08:45:18Z

REHL 8 still has glibc version with 2.32, maybe ubuntu 20.04 is good idea...

remorses · 2026-01-09T09:33:19Z

That was the one I chose at first too but Copilot told me it could get removed soon from Actions. Not sure if true #23 (comment)

fix: use ubuntu-20.04 for GLIBC 2.31 compatibility

753d62d

Copilot AI review requested due to automatic review settings December 30, 2025 17:01

remorses mentioned this pull request Dec 30, 2025

Crash on basic usage remorses/tuistory#1

Closed

Copilot started reviewing on behalf of remorses December 30, 2025 17:01

View session

remorses mentioned this pull request Dec 30, 2025

Cannot open terminal from opencode web anomalyco/opencode#5685

Closed

Copilot AI reviewed Dec 30, 2025

View reviewed changes

Comment thread .github/workflows/publish.yml Resolved

Comment thread .github/workflows/publish.yml Resolved

coderabbitai Bot reviewed Dec 30, 2025

View reviewed changes

Comment thread .github/workflows/publish.yml Resolved

fix: use ubuntu-22.04 instead (20.04 is deprecated)

c262cc5

remorses changed the title ~~fix: use ubuntu-20.04 for GLIBC 2.31 compatibility~~ fix: use ubuntu-22.04 for GLIBC 2.35 compatibility Dec 30, 2025

sursaone merged commit db635ae into sursaone:main Dec 30, 2025
5 checks passed

coderabbitai Bot mentioned this pull request Dec 30, 2025

Create new patch release #24

Merged

Navigation Menu

Repository navigation

fix: use ubuntu-22.04 for GLIBC 2.35 compatibility - #23

fix: use ubuntu-22.04 for GLIBC 2.35 compatibility#23
sursaone merged 2 commits into
sursaone:mainfrom
remorses:fix/use-older-ubuntu-for-glibc-compat

remorses commented Dec 30, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Dec 30, 2025 •

edited

Loading

Other AI code review bot(s) detected

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

yuguorui commented Jan 9, 2026

Uh oh!

remorses commented Jan 9, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

remorses commented Dec 30, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Other AI code review bot(s) detected

Walkthrough

Changes

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

yuguorui commented Jan 9, 2026

Uh oh!

remorses commented Jan 9, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

remorses commented Dec 30, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Dec 30, 2025 •

edited

Loading