don't make_shared inline

emkornfield · pitrou · commit 9f5916070f7f · 2019-07-02T17:58:29.000+02:00
diff --git a/cpp/src/arrow/python/common.cc b/cpp/src/arrow/python/common.cc
@@ -81,8 +81,8 @@ Status PyBuffer::Init(PyObject* obj) {
     }
     return Status::OK();
   } else {
-    return Status(StatusCode::Invalid, "Couldn't convert to buffer.",
-                  std::make_shared<PythonErrorDetail>());
+    auto detail = std::make_shared<PythonErrorDetail>();
+    return Status(StatusCode::Invalid, "Couldn't convert to buffer.", detail);
   }
 }
 
@@ -149,8 +149,8 @@ Status PassPyError() {
   if (PyErr_Occurred()) {
     // Do not call PyErr_Clear, the assumption is that someone further
     // up the call stack will want to deal with the Python error.
-    return Status(StatusCode::UnknownError, "Python Error",
-                  std::make_shared<PythonErrorDetail>());
+    auto detail = std::make_shared<PythonErrorDetail>();
+    return Status(StatusCode::UnknownError, "Python Error", detail);
   }
   return Status::OK();
 }

Original file line number	Diff line number	Diff line change
`@@ -81,8 +81,8 @@ Status PyBuffer::Init(PyObject* obj) {`
`81`	`81`	`}`
`82`	`82`	`return Status::OK();`
`83`	`83`	`} else {`
`84`		`- return Status(StatusCode::Invalid, "Couldn't convert to buffer.",`
`85`		`- std::make_shared<PythonErrorDetail>());`
	`84`	`+ auto detail = std::make_shared<PythonErrorDetail>();`
	`85`	`+ return Status(StatusCode::Invalid, "Couldn't convert to buffer.", detail);`
`86`	`86`	`}`
`87`	`87`	`}`
`88`	`88`
`@@ -149,8 +149,8 @@ Status PassPyError() {`
`149`	`149`	`if (PyErr_Occurred()) {`
`150`	`150`	`// Do not call PyErr_Clear, the assumption is that someone further`
`151`	`151`	`// up the call stack will want to deal with the Python error.`
`152`		`- return Status(StatusCode::UnknownError, "Python Error",`
`153`		`- std::make_shared<PythonErrorDetail>());`
	`152`	`+ auto detail = std::make_shared<PythonErrorDetail>();`
	`153`	`+ return Status(StatusCode::UnknownError, "Python Error", detail);`
`154`	`154`	`}`
`155`	`155`	`return Status::OK();`
`156`	`156`	`}`