classlib: IdentityDictionary passes selector#7062
Merged
telephon merged 2 commits intosupercollider:3.14from Jul 19, 2025
Merged
classlib: IdentityDictionary passes selector#7062telephon merged 2 commits intosupercollider:3.14from
telephon merged 2 commits intosupercollider:3.14from
Conversation
When an IdentityDictionary fails to understand and doesn't know, it should pass the selector when calling doesNotUnderstand on the superclass. This is now the case. This fixes supercollider#7060.
3 tasks
Contributor
|
Since this was a bug (luckily one that hopefully only affects error messages), could you add a test? |
JordanHendersonMusic
approved these changes
Jul 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
Fixes #7060.
Types of changes
To-do list