classlib: kwargs for Pbindef and PbindProxy#6977
Merged
telephon merged 3 commits intosupercollider:3.14from Jun 16, 2025
Merged
classlib: kwargs for Pbindef and PbindProxy#6977telephon merged 3 commits intosupercollider:3.14from
telephon merged 3 commits intosupercollider:3.14from
Conversation
JordanHendersonMusic
approved these changes
Jun 16, 2025
Contributor
JordanHendersonMusic
left a comment
JordanHendersonMusic
left a comment
There was a problem hiding this comment.
Thanks! Yes I forgot about this too — do you think there are any more places in the code base where key value structures are passed as arguments?
dyfer
pushed a commit
to dyfer/supercollider
that referenced
this pull request
Jul 16, 2025
…ile (supercollider#6977) Pbindef and PbindProxy have similar syntax as Pbind now. The Pdef.sc file uses pipes for arguments uniformly. Helpfiles are updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
Since 3.14, we can write
Pbind(freq:8, dur:0.2), for the rc0, I forgot to add the syntax toPbindefandPbindProxy. The change is trivial:pairs = pairs ++ kwargs. I've adjusted the whole file to use pipes as argument syntax.The only functional change is here: 0a522a3
Types of changes
To-do list