NodeTreeView: fix a bug & add scroll to view parent#6948
Merged
dyfer merged 6 commits intosupercollider:3.14from Jun 19, 2025
Merged
NodeTreeView: fix a bug & add scroll to view parent#6948dyfer merged 6 commits intosupercollider:3.14from
dyfer merged 6 commits intosupercollider:3.14from
Conversation
Contributor
Author
This code does not produce a vertical scroll when evaluated. This functionality was implemented this way prior to the introduction of issue #6294. |
Contributor
Author
|
@dyfer |
Contributor
Author
|
@capital-G, @dyfer |
Member
Contributor
Author
|
As |
telephon
reviewed
Jun 13, 2025
telephon
approved these changes
Jun 13, 2025
Member
telephon
left a comment
There was a problem hiding this comment.
might be better with layouts, but for now it is good.
dyfer
requested changes
Jun 18, 2025
dyfer
requested changes
Jun 19, 2025
Member
dyfer
left a comment
There was a problem hiding this comment.
Thanks for the changes! I have small outstanding requests.
dyfer
pushed a commit
to dyfer/supercollider
that referenced
this pull request
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
#6294 introduces the following error
when evaluating the following code:
This PR fixes this wrong behaviour. (SC3.13.0 does not return this error and creates the requested GUI.)
(In #6834, #6853, #6914 and #6917, this bug is not addressed.)
Types of changes
To-do list