Merged
Conversation
Contributor
Author
|
All tests with #6914 passed. |
dyfer
requested changes
Jun 1, 2025
Member
dyfer
left a comment
There was a problem hiding this comment.
Thanks!
This does seem to fix all node plotting.
However, could you change the Colors back to the ones using globalAlpha parameter? This will make the plot "fade" slightly when the server quits, which isn't happening in this PR.
Contributor
Author
Done in 8029b19 I'm sorry, I didn't realise that I removed this. Is this now ok? |
Member
|
Yes, it's good now, thanks! |
dyfer
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and Motivation
Fixes the following problems
The commit for resolving the problem in #6834 is problematic due to its complicated structure; there are too many if clauses, which makes it very complex and confusing. In this implementation, I reinstated the algorithm from before #6834 and made a few minor changes to the countSize function. While not perfect, this is a significant improvement on my previous implementation.
To test extreme cases
! 15to! 100or! 202Types of changes
To-do list