QT: remove deprecations for QT 5.15#6464
Conversation
This has no effect and no replacement, can be safely removed
This might need revisiting
This might need revisiting
This might need revisiting
instead of QStyleOptionTabV3
and replace it with a regular QString, since it's only available through a compatibility layer in Qt6
|
Anybody interested in reviewing this? Qt6 is waiting... 😀 @JordanHendersonMusic @capital-G @telephon |
JordanHendersonMusic
left a comment
JordanHendersonMusic
left a comment
There was a problem hiding this comment.
This seems like a very clear one to one translation.
I did wonder about load and load relaxed, but the docs say load was relaxed.
Bring on qt6!!
capital-G
left a comment
capital-G
left a comment
There was a problem hiding this comment.
Thanks so much for this step towards Qt6 :)
| #include "../doc_manager.hpp" | ||
|
|
There was a problem hiding this comment.
just out of curiosity - how do the occasional additional new imports are coming into place here? Are they Qt specific, do they help the compiler/IDE to be more explicit or are these just left-overs from development?
There was a problem hiding this comment.
They were fixing building errors with Qt6. I guess technically they shouldn't be part of this PR :), but since they still work with Qt 5.15, then I don't think it hurts anything.
There was a problem hiding this comment.
Interesting. Looking forward to the Qt6 PR :)
There was a problem hiding this comment.
Coming up! Once the previous CI passes, so that we have that brew universal cache...
4 participants
Purpose and Motivation
This PR provides updates and fixes for the deprecations up to Qt 5.15.
This is an "intermediary" PR, extracted from the Qt6 update branch for easier review. It generally does not include Qt6 code explicitly, even though commits do mention qt6...
Thanks @jrsurge for starting this work back in the day! A number of commits were extracted from @jrsurge's qt6 branch.
This PR also raises the minimum supported QT to 5.15; however I'd wait with updating documentation until the Qt6 updates are finalized.
Please review carefully! I'm not confident in C++ nor in Qt :)
Types of changes
To-do list