Added Portuguese translations by Edu-Amorim · Pull Request #2 · superbacked/superbacked

Edu-Amorim · 2025-03-30T21:45:57Z

This PR introduces full Brazilian Portuguese (pt) support for the application.

sunknudsen · 2025-05-23T09:11:03Z

Hey @Edu-Amorim, I didn’t forget about this PR. I reached out to a friend to see if he has time to review PR before it is merged.

sunknudsen · 2025-05-23T09:57:21Z

While I wait for feedback from my friend (who speaks Brazilian Portuguese) , I asked ChatGPT to compare translations in this PR to en.json and this is the feedback provided. Given I don’t speak Portuguese, does any of this feedback apply?

Also, can you please use ellipsis character … vs dot dot dot ...?

ChatGPT feedback below:

Yes, the Portuguese JSON you provided is generally a correct and equivalent translation of the English entries found in en.json, and the locale used is Brazilian Portuguese (pt-BR).

✅ Equivalence Check

All menu items (menu.superbacked, file, edit, insert, view) match in meaning.
Structural keys like secretRequired, passphraseStrength, copy, create, print, and unlock are correctly translated.
Pluralization support (validBip39Mnemonic_one/other, totpUri_one/other) is preserved.
Complex warnings and terms of use (e.g., superbackedIncCannotBeHeldResponsible, useAtYourOwnRisk) are accurate and idiomatic.

⚠️ Minor Observations / Suggestions

Typographic Consistency
- In typeSecret, the English uses an ellipsis (…) while the Portuguese uses .... Consider using the ellipsis character … for consistency:
  - Current: "Digite o segredo..."
  - Suggested: "Digite o segredo…"
Grammar
- "para gerenciamento de segredos, a menos que o segredo já esteja presente no computador" is grammatically correct, but could be slightly more fluent as:
  - Suggested: "a menos que o segredo já esteja presente neste computador." (adds a bit more emphasis and clarity with "neste")
Localization Style
- "Aviso" is used for both "headsUp" and "warning"—though valid, differentiating with "Atenção" for "headsUp" might be more nuanced:
  - "headsUp" → "Atenção"
  - "warning" → "Aviso"
"Senha de recuperação"
- This translation for "passphrase" is functionally accurate and user-friendly. However, some cryptographic contexts may prefer "frase secreta" or "senha frase" depending on the app's audience.

✅ Summary

✅ Functional equivalence: Yes
✅ Locale match: Yes (pt-BR)
✅ No critical typos found
⚠️ Minor stylistic and consistency enhancements are recommended

sunknudsen · 2025-05-23T10:00:40Z

Now, another thing that comes to mind before merging this PR is that someone might want to translate app to another country-specific version of Portuguese.

Perhaps it is time to support pt-BR type locales? Have to investigate how much of a refactor this would be.

irae

Hi Edu. I've added a number of comments, but the only thing I would think is required for us to change is the "passphrase" translation. My first comment on it has a deep research using ChatGPT to help you understand how other software uses its meaning. So everywhere I looked to change to "frase secreta" instead of your translation.

All other comments are minor and optional, but please think about "air-gapped" too, as I think might be better to keep the english version in parenthesis, it would prompt people to research what it means.

Also, thanks, Sun, to inviting me to help with the translation <3

src/locales/pt.json

irae · 2025-05-25T14:22:33Z

src/locales/pt.json

+  },
+  "doNot": "Não",
+  "useSuperbackedOnComputer": "use o Superbacked em um computador que não seja",
+  "airGapped": "isolado",


It is a shame we, in portuguese, don't have the same term as in "air-gapped" with a literal translation. I would use "totalmente isolado" (completely isolated) in this context. Or maybe even better: "isolado (air-gapped)". Let me know what you think in this case, since it is of upmost importance that it is well understood.

Hello @irae,
To be honest, I haven't encountered that expression in Portuguese either, only in English.

I plan to go ahead with a direct translation of @sunknudsen's French version ("isolé d’Internet") and incorporate your suggestion to include the original term in parentheses.

The updated entry will look like this:

- "airGapped": "isolado", + "airGapped": "isolado da internet (air-gapped)",

src/locales/pt.json

irae · 2025-05-25T14:51:11Z

Perhaps it is time to support pt-BR type locales?

@sunknudsen Brazilian Portuguese kinda took over already. Even in Portugual the language is slowly changing towards the Brazilian portuguese style. I rarely see software translated in both, and my own impression is that the vast majority of texts translated only to one Portuguese is Brazilian nowadays.

I am not at all against having the two, but I would leave as is and change it to pt-BR if someone finds it necessary and puts the effort to have the Portugal version in addition.

irae · 2025-05-25T15:02:17Z

Lastly, I agree with ChatGPT points 1, 2 and 3. The 4th point I agree needs changing, but not to what ChatGPT posted by Sun, suggested as replacement, as stated in one of my code comments.

sunknudsen · 2025-05-28T12:01:15Z

Hey @Edu-Amorim, thanks again for submitting PR… have a moment to review comments?

This commit updates the Portuguese translations in response to the comments provided in the PR. The following terms have been revised: 1. ... -> … (ellipsis character) 2. "Senha de recuperação" -> "Frase secreta" 3. "Escanear código QR" -> "Ler código QR" 4. "Força da frase secreta" -> "Complexidade da frase secreta" 5. "Frase secreta muito similar" -> "Frase secreta muito parecida" 6. "[...] a menos que o segredo já esteja presente no computador." -> "[...] a menos que o segredo já esteja presente neste computador." 7. "headsUp": "Aviso" -> "headsUp": "Atenção" 8. "isolado" -> "isolado da internet (air-gapped)"

irae

Thanks for the update! Looks like everything was covered!

sunknudsen · 2025-06-08T11:36:42Z

Thanks for contributing @Edu-Amorim and @irae… Portuguese translations will be included in 1.7.3 release.

sunknudsen · 2025-06-21T12:41:49Z

Released as v1.8.0 given I had to drop universal macOS target due to upstream breaking change

Added Portuguese translations

25f2139

Edu-Amorim force-pushed the translation-pt branch from cfed6d1 to 25f2139 Compare March 30, 2025 21:53

irae suggested changes May 25, 2025

View reviewed changes

Edu-Amorim requested a review from irae June 6, 2025 18:45

irae approved these changes Jun 6, 2025

View reviewed changes

sunknudsen merged commit 363374c into superbacked:main Jun 8, 2025

Conversation

Edu-Amorim commented Mar 30, 2025

Uh oh!

sunknudsen commented May 23, 2025

Uh oh!

sunknudsen commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Equivalence Check

⚠️ Minor Observations / Suggestions

✅ Summary

Uh oh!

sunknudsen commented May 23, 2025

Uh oh!

irae left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

irae May 25, 2025

Choose a reason for hiding this comment

Uh oh!

Edu-Amorim Jun 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

irae commented May 25, 2025

Uh oh!

irae commented May 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sunknudsen commented May 28, 2025

Uh oh!

irae left a comment

Choose a reason for hiding this comment

Uh oh!

sunknudsen commented Jun 8, 2025

Uh oh!

sunknudsen commented Jun 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sunknudsen commented May 23, 2025 •

edited

Loading

irae left a comment •

edited

Loading

irae commented May 25, 2025 •

edited

Loading