Fixed another block image issue on Tails OS running on ThinkPad X1 Carbon Gen 10 where device pixel ratio is 1.25 (“Scale” is set to “125%” in “Displays”).

Fractional scale resulted in fractional window size throwing a type error… fixed in v1.9.0-rc.4 release.

Hey @sunknudsen,

I have tested Superbacked OS on my ThinkPad X1 Carbon Gen 13 and can confirm that the backup type hang and the block scaling issues reported from v1.9.0-rc.1 release now have been fixed in v1.9.0-rc.4.

I did however find another issue when trying to restore a distributed backup from a file. Here are the steps to reproduce:

1. Create a distributed backup (2 of 3 blocks required).

2. Save the files to disk.

3. Open 2 of the 3 blocks in Image Viewer.

4. Select source.

5. Enter passphrase.

When given the correct passphrase the same screen is shown again with the message "Scan next block..." and the clicking sound repeats multiple times. Seems like it's attempting to scan the same block again and again.

6. Switch to show the second backup in Image Viewer.

7. Click the cog in top right corner and select source again.

Now the following "blank" screen appears.

8. Click the cog and select source one more time. It now presents a different type of screen sharing window.

9. Select "Application Window" to share the same window from Image Viewer again.

This time it does work and the correct secret is restored.

Hey @sunknudsen,

I can also confirm that scanning blocks to restore backups (both standard and distributed) works well in good lighting using the integrated camera on my ThinkPad X1 Carbon Gen 13 👍

Hey @christoffercarlsson, first, thank you so much for such a well documented issue. 🙌

I believe distributed backup recovery via screen sharing issue is something that was reported in the past… on it!

I can also confirm that scanning blocks to restore backups (both standard and distributed) works well in good lighting using the integrated camera on my ThinkPad X1 Carbon Gen 13 👍

Great, thanks for sharing! I don’t recall if I asked but do you have the model with a 1080p or 8K camera?

Great, thanks for sharing! I don’t recall if I asked but do you have the model with a 1080p or 8K camera?

It's the 1080p model. 8K would be nice, though!

Great, thanks for sharing! I don’t recall if I asked but do you have the model with a 1080p or 8K camera?

It's the 1080p model. 8K would be nice, though!

Not sure if Ubuntu includes non-proprietary drivers for 8K camera.

Hey @christoffercarlsson, please see v1.9.0-rc.5. This release candidate should fix the reported recovery issue on Linux.

TL;DR; The desktopCapturer.getSources API has caveats on Linux when using Wayland. First, one cannot select multiple windows even though Ubuntu’s UI allows it. Second, Wayland does not reveal window name to Electron (see electron/electron#47793).

As a result, I refactored Scanner component to automatically update devices and sources when Mantine’s Select component is clicked and automatically select source (window) provided by Wayland/PipeWire. This fixes confusing UX and having to first allow window and then select same window.

That said, I believe there was also a race condition in how start and stop were handled.

Hey @sunknudsen,

I've tested v1.9.0-rc.5, and I was unable to reproduce the recovery issue for distributed backups that was reported earlier. So that seems to be fixed now 👍

I did run into the block scaling issue again though. I am also unable to deterministically reproduce this on my hardware, same as you.

Hey @christoffercarlsson!

That issue is stubborn… thanks for your help.

Ended up reverting back to [email protected] vs Electron’s capturePage.

Among other desirable properties, pdfjs-dist supports deterministic scaling no matter the resolution or scale of monitor.

Please see v1.9.0-rc.6 release.

Hey @christoffercarlsson! I fixed another issue… please see v1.9.0-rc.7 release.

Hey @sunknudsen,

I can happily confirm that the block scaling issue have been fixed with v1.9.0-rc.7 release!

I would say that v1.9.0 is ready to be merged 🥳

Hey @christoffercarlsson, I anchored semver to v1.9.0.

Merge is pending final review.