Repository navigation
fix(op-log): skip compaction while boot hydration replay is in progress (#9084) - #9568
Merged
johannesjo merged 3 commits intoAug 14, 2026
Conversation
Contributor
Preview Deployment
Branch: Deployed with Cloudflare Pages |
hydrateStore() now flags hydration-in-progress at the start of every run (super-productivity#9084), so the hand-rolled HydrationStateService stub in the retry integration spec must provide the setter too — without it all three of this file's boots fail with a TypeError, which is what broke the Tests job on CI.
…lag inside try - Correct the reachability story in every comment copy: the cold-boot trigger cited before (TODAY_TAG repair on loadAllData) cannot fire — skipDuringSyncWindow() requires isInitialSyncDoneSync(), which only flips after hydrateStore() resolves. The live windows are re-entrant hydration (PluginAPI.reInitData()) in a session past the compaction threshold, and the legacy-snapshot compact() in RemoteOpsProcessingService. Also avoid claiming the compaction counter is persisted across restarts — it is not (super-productivity#8336); the retrigger works because a skipped compaction leaves the in-memory counter over threshold. - Keep one canonical explanation at the guard in _doCompact and trim the four other copies to short pointers (super-productivity#9140 style). - Set the hydration-in-progress flag inside the try block so a throw still reaches the recovery path; the finally clears it on every exit either way.
Collaborator
|
Thank you very much! <3 |
This was referenced Sep 23, 2026
This was referenced Oct 9, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small, targeted change to src/app/op-log/apply/hydration-state.service.ts, .../operation-log-compaction.service.spec.ts, .../operation-log-compaction.service.ts, .../operation-log-hydrator.service.spec.ts and a few others that resolves the reported issue without touching anything unrelated. Fixes #9084.
I pushed this to my fork first and the project's own CI workflows pass on the commit.