Repository navigation
fix(patches): 🚨 Cannot connect to CalDAV Todo issue provider - #9530
Merged
johannesjo merged 1 commit intoAug 14, 2026
Merged
johannesjo merged 1 commit into
johannesjo merged 1 commit into
Conversation
Contributor
Preview Deployment
Branch: Deployed with Cloudflare Pages |
2 tasks
Collaborator
|
Thank you very much! <3 |
johannesjo
added a commit
that referenced
this pull request
Aug 15, 2026
* fix(release): strip emoji from the App Store "What's New" text Both Apple release lanes failed for 18.20.0 with An attribute value has invalid characters. - What's New in This Version can't contain the following character(s): 🚨. - /data/attributes/whatsNew App Store Connect blocks some emoji in whatsNew, and no one wrote that one by hand: the bug-report issue template prefixes titles with "🚨 ", the squash merge for #9530 carried it into the commit subject, and the changelog generator turned it into a release-note bullet. Apple documents neither the blocked set nor when it changes, so the App Store transform now strips pictographs wholesale rather than tracking a blocklist -- the same deliberately aggressive bias already used for non-Apple platform names, where a miss costs a failed release and an over-eager match only costs decoration. Lines left as bare bullets or headings are dropped so nothing dangles. Only the App Store text is affected; the GitHub and Play Store changelogs keep their emoji. Verified end to end by regenerating the real 18.20.0 notes: the rejected bullet now reads "• Cannot connect to CalDAV Todo issue provider (#9530)" and the output is emoji-free. Co-Authored-By: Claude <[email protected]> Claude-Session: https://claude.ai/code/session_01Vg413FSRvrm92TTe2x4UDv * test(release): pin every emoji class the App Store transform strips Review of the previous commit mutation-tested EMOJI_PATTERN and found two members whose removal left the whole suite green: \p{Emoji_Modifier} and \u{FE0E}. Both leave residue that is invisible in a diff -- dropping the skin-tone half of "👋🏽" ships a bare U+1F3FD to Apple -- so the gap would have surfaced as a failed release lane, which is exactly what these tests exist to prevent. Cause was assertNoEmoji checking a hand-written subset of what the code strips. It now builds its regex from the exported EMOJI_PATTERN, so the assertion can never drift narrower than the implementation again, with a case per member to pin them. (The /g flag is dropped when rebuilding: a global regex carries lastIndex between test() calls.) Also closes the one gap the review could still construct an input for: emoji tag sequences (U+E0020-U+E007F). "🏴" lost its base pictograph but kept six invisible tag characters, so Apple would have rejected the text naming a character that renders as nothing. Widen LINE_MARKERS_ONLY to the "+", "_" and ">" markers the AI generation path can emit while here, so an emoji-only line under those leaves no stray marker either. Mutation-verified: each of the eight members of EMOJI_PATTERN now fails at least one test when removed. Co-Authored-By: Claude <[email protected]> Claude-Session: https://claude.ai/code/session_01Vg413FSRvrm92TTe2x4UDv --------- Co-authored-by: Claude <[email protected]>
This was referenced Sep 23, 2026
This was referenced Oct 9, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small, targeted change to patches/@nextcloud+cdav-library+1.5.3.patch, .../providers/caldav/caldav-client.service.spec.ts that resolves the reported issue without touching anything unrelated.
Ran this through the project's own CI on my fork before opening it, all green.
Fixes #9428.