Skip to content

fix(patches): 🚨 Cannot connect to CalDAV Todo issue provider - #9530

Merged
johannesjo merged 1 commit into
super-productivity:masterfrom
AlvaroBalbin:issue-9428-cannot-connect-to-caldav
Aug 14, 2026
Merged

johannesjo merged 1 commit into
super-productivity:masterfrom
AlvaroBalbin:issue-9428-cannot-connect-to-caldav

Conversation

@AlvaroBalbin

Copy link
Copy Markdown
Contributor

This is a small, targeted change to patches/@nextcloud+cdav-library+1.5.3.patch, .../providers/caldav/caldav-client.service.spec.ts that resolves the reported issue without touching anything unrelated.

Ran this through the project's own CI on my fork before opening it, all green.

Fixes #9428.

@github-actions

Copy link
Copy Markdown
Contributor

Preview Deployment

Status URL
Deployed https://430534e0.super-productivity-preview.pages.dev

Branch: issue-9428-cannot-connect-to-caldav
Commit: 8cca125


Deployed with Cloudflare Pages

@johannesjo

Copy link
Copy Markdown
Collaborator

Thank you very much! <3

@johannesjo
johannesjo merged commit bc28a66 into super-productivity:master Aug 14, 2026
18 checks passed
johannesjo added a commit that referenced this pull request Aug 15, 2026
* fix(release): strip emoji from the App Store "What's New" text

Both Apple release lanes failed for 18.20.0 with

  An attribute value has invalid characters. - What's New in This Version
  can't contain the following character(s): 🚨. - /data/attributes/whatsNew

App Store Connect blocks some emoji in whatsNew, and no one wrote that one
by hand: the bug-report issue template prefixes titles with "🚨 ", the
squash merge for #9530 carried it into the commit subject, and the
changelog generator turned it into a release-note bullet.

Apple documents neither the blocked set nor when it changes, so the
App Store transform now strips pictographs wholesale rather than tracking a
blocklist -- the same deliberately aggressive bias already used for
non-Apple platform names, where a miss costs a failed release and an
over-eager match only costs decoration. Lines left as bare bullets or
headings are dropped so nothing dangles.

Only the App Store text is affected; the GitHub and Play Store changelogs
keep their emoji.

Verified end to end by regenerating the real 18.20.0 notes: the rejected
bullet now reads "• Cannot connect to CalDAV Todo issue provider (#9530)"
and the output is emoji-free.

Co-Authored-By: Claude <[email protected]>
Claude-Session: https://claude.ai/code/session_01Vg413FSRvrm92TTe2x4UDv

* test(release): pin every emoji class the App Store transform strips

Review of the previous commit mutation-tested EMOJI_PATTERN and found two
members whose removal left the whole suite green: \p{Emoji_Modifier} and
\u{FE0E}. Both leave residue that is invisible in a diff -- dropping the
skin-tone half of "👋🏽" ships a bare U+1F3FD to Apple -- so the gap would
have surfaced as a failed release lane, which is exactly what these tests
exist to prevent.

Cause was assertNoEmoji checking a hand-written subset of what the code
strips. It now builds its regex from the exported EMOJI_PATTERN, so the
assertion can never drift narrower than the implementation again, with a
case per member to pin them. (The /g flag is dropped when rebuilding: a
global regex carries lastIndex between test() calls.)

Also closes the one gap the review could still construct an input for:
emoji tag sequences (U+E0020-U+E007F). "🏴󠁧󠁢󠁥󠁮󠁧󠁿" lost its base pictograph but
kept six invisible tag characters, so Apple would have rejected the text
naming a character that renders as nothing. Widen LINE_MARKERS_ONLY to the
"+", "_" and ">" markers the AI generation path can emit while here, so an
emoji-only line under those leaves no stray marker either.

Mutation-verified: each of the eight members of EMOJI_PATTERN now fails at
least one test when removed.

Co-Authored-By: Claude <[email protected]>
Claude-Session: https://claude.ai/code/session_01Vg413FSRvrm92TTe2x4UDv

---------

Co-authored-by: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🚨 Cannot connect to CalDAV Todo issue provider

2 participants