fix(auth): downgrade aborted/transient fetch failures from console.error to warn#2544
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAuth fetch failures remain retryable without raw logging. During initial session emission and session recovery, retryable fetch/network failures use Sequence Diagram(s)sequenceDiagram
participant Fetch
participant GoTrueClient
participant Console
Fetch->>GoTrueClient: Throw AuthRetryableFetchError
GoTrueClient->>Console: Log retryable failure with console.warn
GoTrueClient->>GoTrueClient: Leave session unchanged for later recovery
Assessment against linked issues
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@supabase/auth-js
@supabase/functions-js
@supabase/postgrest-js
@supabase/realtime-js
@supabase/storage-js
@supabase/supabase-js
commit: |
mandarini
marked this pull request as ready for review
July 21, 2026 12:45
Contributor
|
The following capabilities are marked
These may have been renamed, removed, or never registered. Please update the capability matrix. |
spydon
approved these changes
Jul 21, 2026
|
coverage: 80.673% (+0.04%) from 80.631% — fix/auth-transient-fetch-console-noise into master |
mandarini
force-pushed
the
fix/auth-transient-fetch-console-noise
branch
from
July 21, 2026 13:05
aafcf0a to
5fe53e5
Compare
This was referenced Jul 21, 2026
mandarini
pushed a commit
to supabase/supabase
that referenced
this pull request
Jul 22, 2026
This PR updates @supabase/*-js libraries to version 2.110.8. **Source**: supabase-js-stable-release **Changes**: - Updated @supabase/supabase-js to 2.110.8 - Updated @supabase/auth-js to 2.110.8 - Updated @supabase/realtime-js to 2.110.8 - Updated @supabase/postgest-js to 2.110.8 - Refreshed pnpm-lock.yaml --- ## Release Notes ## v2.110.8 ## 2.110.8 (2026-07-21) ### 🩹 Fixes - **auth:** downgrade aborted/transient fetch failures from console.error to warn ([#2544](supabase/supabase-js#2544)) - **functions:** clean up cross-signal abort listener on invoke() return ([#2487](supabase/supabase-js#2487)) - **functions:** match response Content-Type case-insensitively ([#2515](supabase/supabase-js#2515)) - **storage:** url-encode object key in CDN purge methods ([#2545](supabase/supabase-js#2545)) - **supabase:** skip Node warning in Deno ([#2541](supabase/supabase-js#2541)) ### ❤️ Thank You - Franco Kaddour @FrancoKaddour - Katerina Skroumpelou @mandarini - Pedro Henrique - Vaibhav @7ttp ## v2.110.7 ## 2.110.7 (2026-07-16) ### 🩹 Fixes - **postgrest:** correct self-reference inference ([#2525](supabase/supabase-js#2525)) - **realtime:** trigger set auth on INITIAL_SESSION event ([#2531](supabase/supabase-js#2531)) - **realtime:** update phoenix to fix presence issue ([#2532](supabase/supabase-js#2532)) ### ❤️ Thank You - Eduardo Gurgel - Filipe Cabaço @filipecabaco - Vaibhav @7ttp This PR was created automatically. Co-authored-by: supabase-workflow-trigger[bot] <266661614+supabase-workflow-trigger[bot]@users.noreply.github.com>
mandarini
pushed a commit
to supabase/ssr
that referenced
this pull request
Jul 22, 2026
This PR updates `@supabase/supabase-js` to v2.110.8. **Source**: supabase-js-stable-release --- ## Release Notes ## v2.110.8 ## 2.110.8 (2026-07-21) ### 🩹 Fixes - **auth:** downgrade aborted/transient fetch failures from console.error to warn ([#2544](supabase/supabase-js#2544)) - **functions:** clean up cross-signal abort listener on invoke() return ([#2487](supabase/supabase-js#2487)) - **functions:** match response Content-Type case-insensitively ([#2515](supabase/supabase-js#2515)) - **storage:** url-encode object key in CDN purge methods ([#2545](supabase/supabase-js#2545)) - **supabase:** skip Node warning in Deno ([#2541](supabase/supabase-js#2541)) ### ❤️ Thank You - Franco Kaddour @FrancoKaddour - Katerina Skroumpelou @mandarini - Pedro Henrique - Vaibhav @7ttp This PR was created automatically. Co-authored-by: supabase-workflow-trigger[bot] <266661614+supabase-workflow-trigger[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a page load starts GoTrueClient session recovery and the user navigates away before it settles, the browser aborts the in-flight auth request. The rejection (
TypeError: Failed to fetch) was logged raw viaconsole.error, polluting production consoles and breaking strict zero-console-error E2E gates, even though nothing is actually wrong (the page was simply superseded).These failures are already modeled as
AuthRetryableFetchErrorand treated as transient elsewhere in auth-js. This PR brings the logging in line: it removes the unconditional rawconsole.errorin the fetch helper (_handleRequest) and downgrades retryable fetch failures toconsole.warnin theINITIAL_SESSIONemission and_recoverAndRefresh, using the existingisAuthRetryableFetchErrordiscriminator. Genuine non-retryable errors still log atconsole.error. This is a log-level change only, with no behavior or API change, and adds tests covering all three paths.Note for reviewers: removing the fetch-helper log affects all failed fetches (not just aborts), so a genuine CORS/network failure during e.g.
signInWithPasswordno longer logs at the fetch layer; it still surfaces to the caller via the returnederror.Closes #2543